Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microsoft_gsl: 3.1.0 -> 4.0.0 #231860

Closed
wants to merge 1 commit into from

Conversation

cbourjau
Copy link
Contributor

Release notes: https://github.com/microsoft/GSL/releases/tag/v4.0.0

Version 3.1.0 is still available as microsoft_gsl_3. I am not sure if this is necessary, but affected packages don't build on MacOS.

Once merged we can use this package in #226734

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Release notes: https://github.com/microsoft/GSL/releases/tag/v4.0.0

Version 3.1.0 is still available as microsoft_gsl_3.
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 14, 2023
@ofborg ofborg bot requested a review from thoughtpolice May 14, 2023 15:57
@Aleksanaa
Copy link
Member

Once merged I can update ueberzugpp 2.8.1 -> 2.8.3.

@wegank
Copy link
Member

wegank commented May 21, 2023

Oh, I didn't notice that before #232811. Sorry.

@wegank wegank closed this May 21, 2023
@cbourjau cbourjau deleted the update-microsoft-gsl branch May 21, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants