echidna: fix build due to brick-1.9 #251919
Conversation
|
@ofborg build echidna |
|
1 package built: Result of 1 package built:
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2601 |
| # Note: pending PR https://github.com/crytic/echidna/pull/1096 | ||
| patches = [ ./brick-1.9.patch ]; |
There was a problem hiding this comment.
Can you pull this from upstream (with fetchpatch)?
We generally try not to check patches in to Nixpkgs if it can be avoided in any way.
Also, we generally ask for Haskell-related PRs to be based on haskell-updates, since we have CI for these Haskell-based programs like echidna.
There was a problem hiding this comment.
I see, there is no upstream patch yet unfortunately.
There was a problem hiding this comment.
Ah, so crytic/echidna#1096 is the upstream patch, right? You should be able to pull specific commits/files from a GitHub PR using fetchpatch.
Take a look in pkgs/development/haskell-modules/configuration-*.nix, there should be various uses of fetchpatch for pulling patches from specific commits/files from GitHub PRs.
There was a problem hiding this comment.
I see let me check with their upstream packaging status. There was a report of something not working.
There was a problem hiding this comment.
Done re using fetchpatch, thanks!
Re haskell-updates, I would like to contend that. Some "leaf" packages are not published to the hackage, and simply using the hackages to download dependencies. I would like these packages to continue to be tested against the master instead.
- use fetchpatch
hellwolf
force-pushed
the
echidna-brick-1.9-fix
branch
from
b0d8ef7 to
e6f657b
Compare
|
@ofborg build echidna |
|
changed base to haskell-updates @cdepillabout |
|
@ofborg build echidna |
|
Great, thanks for fixing this! |
Description of changes
Fix build due to brick-1.9 update from the haskellPackages.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)