Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freshBootstrapTools.bootstrapTools: fix eval on darwin #253759

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Sep 7, 2023

error: undefined variable 'system'
       at /home/artturin/nixgits/my-nixpkgs/.worktree/1/pkgs/stdenv/darwin/make-bootstrap-tools.nix:213:32:

          212|
          213|   bootstrapTools = derivation {
             |                                ^
          214|     inherit system;

fixes eval of freshBootstrapTools.bootstrapTools in darwin repl

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Artturin Artturin requested a review from stephank September 7, 2023 01:23
@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Sep 7, 2023
```
error: undefined variable 'system'
       at /home/artturin/nixgits/my-nixpkgs/.worktree/1/pkgs/stdenv/darwin/make-bootstrap-tools.nix:213:32:

          212|
          213|   bootstrapTools = derivation {
             |                                ^
          214|     inherit system;

```

fixes eval of `freshBootstrapTools.bootstrapTools` in darwin repl
@Artturin Artturin changed the title freshBootstrapTools.bootstrapTools: fix eval freshBootstrapTools.bootstrapTools: fix eval on darwin Sep 7, 2023
@wegank wegank requested a review from reckenrode September 7, 2023 01:30
@wegank
Copy link
Member

wegank commented Sep 7, 2023

The error doesn't seem to be reproducible on my machine...?

@Artturin
Copy link
Member Author

Artturin commented Sep 7, 2023

Aha! The top-level system is an alias and I have aliases disabled and on line 16 with ...pkgs is used.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 7, 2023
@Artturin Artturin merged commit 0974af1 into NixOS:master Sep 7, 2023
13 checks passed
@Artturin Artturin deleted the fixevaldarwin branch September 7, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants