Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotdl: 4.2.2 -> 4.2.4 #272641

Merged
merged 1 commit into from
Dec 9, 2023
Merged

spotdl: 4.2.2 -> 4.2.4 #272641

merged 1 commit into from
Dec 9, 2023

Conversation

picnoir
Copy link
Member

@picnoir picnoir commented Dec 7, 2023

Some tests have been renamed. We also disable some new tests requiring network connectivity.

Tested locally.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Some tests have been renamed. We also disable some new tests requiring
network connectivity.
@picnoir picnoir added 9.needs: port to stable A PR needs a backport to the stable release. backport staging-23.11 and removed 9.needs: port to stable A PR needs a backport to the stable release. backport staging-23.11 labels Dec 7, 2023
@picnoir picnoir merged commit 29558c0 into NixOS:master Dec 9, 2023
29 checks passed
Copy link
Contributor

github-actions bot commented Dec 9, 2023

Successfully created backport PR for release-23.11:

@picnoir picnoir deleted the pic/spotdl424 branch December 9, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant