Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android-studio-for-platform: init at 2023.2.1.20 #278361

Merged
merged 2 commits into from
Jul 2, 2024
Merged

android-studio-for-platform: init at 2023.2.1.20 #278361

merged 2 commits into from
Jul 2, 2024

Conversation

robbins
Copy link
Contributor

@robbins robbins commented Jan 2, 2024

Description of changes

android-studio-for-platform is a variant of the Android Studio IDE designed specifically for working on AOSP.
homepage: https://developer.android.com/studio/platform

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@robbins
Copy link
Contributor Author

robbins commented Jan 2, 2024

Had a previous PR open here: #269108 but forgot about it and deleted my fork of nixpkgs, which closed the pull request.

I will be re-testing to see if the errors I mentioned in the comments of that PR still exist or if they impact any functionality.

@robbins robbins force-pushed the android-studio-for-platform branch from 3f12670 to 21065d0 Compare January 2, 2024 22:23
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 2, 2024
@BenediktBroich
Copy link
Contributor

Result of nixpkgs-review pr 278361 run on x86_64-linux 1

1 package built:
  • android-studio-for-platform

@robbins robbins changed the title android-studio-for-platform: init at 2023.1.1.19 android-studio-for-platform: init at 2023.2.1.20 Feb 14, 2024
@robbins
Copy link
Contributor Author

robbins commented Feb 14, 2024

Had a previous PR open here: #269108 but forgot about it and deleted my fork of nixpkgs, which closed the pull request.
I will be re-testing to see if the errors I mentioned in the comments of that PR still exist or if they impact any functionality.

Fixed the Soong sync errors found there.

@shymega
Copy link

shymega commented Mar 15, 2024

If you need testers for this PR, let me know. I'm running NixOS on x86_64 Linux, and have several AOSP trees to work with. I have around 32GB of RAM.

I was just about to start work on a branch, but no need now. Good luck!

eyJhb added a commit to eyJhb/robotnix that referenced this pull request Mar 31, 2024
@eyJhb
bumps nixpkgs to 23.11 and android-nixpkgs, remove nixpkgsUnstable
5159898 
This commit bumps nixpkgs to 23.11, while incorporating small changes
to ensure everything works.
At the same time, nixpkgsUnstable has been removed as it does not seem
to be needed anymore.
android-nixpkgs has been bumped to the latest version as well.

`LD_LIBRARY_PATH` paths has been added to buildFHSUSerEnv, because of
upstream changes. Please see the following information if curious.

NixOS/nixpkgs#103648
NixOS/nixpkgs#112266

NixOS/nixpkgs#262775
NixOS/nixpkgs#263201

NixOS/nixpkgs#278361
@eyJhb eyJhb mentioned this pull request Mar 31, 2024
Merged
@robbins robbins force-pushed the android-studio-for-platform branch 2 times, most recently from a090f02 to 99a98f6 Compare April 22, 2024 21:27
@robbins
Copy link
Contributor Author

robbins commented Apr 22, 2024

If you need testers for this PR, let me know. I'm running NixOS on x86_64 Linux, and have several AOSP trees to work with. I have around 32GB of RAM.

I was just about to start work on a branch, but no need now. Good luck!

@shymega Sure! I've just updated this PR with both the stable and canary releases, and from my usage everything seems to be working correctly, but it would be great to know if you come across any issues.

Atemu pushed a commit to jaen/robotnix that referenced this pull request Jun 5, 2024
@eyJhb @Atemu
bumps nixpkgs to 23.11 and android-nixpkgs, remove nixpkgsUnstable
8dffd27 
This commit bumps nixpkgs to 23.11, while incorporating small changes
to ensure everything works.
At the same time, nixpkgsUnstable has been removed as it does not seem
to be needed anymore.
android-nixpkgs has been bumped to the latest version as well.

`LD_LIBRARY_PATH` paths has been added to buildFHSUSerEnv, because of
upstream changes. Please see the following information if curious.

NixOS/nixpkgs#103648
NixOS/nixpkgs#112266

NixOS/nixpkgs#262775
NixOS/nixpkgs#263201

NixOS/nixpkgs#278361
@robbins robbins force-pushed the android-studio-for-platform branch from 99a98f6 to 67c5963 Compare June 25, 2024 21:03
@robbins
Copy link
Contributor Author

robbins commented Jun 25, 2024

Also removed some un-needed dependencies in the latest push.

@robbins robbins requested a review from Artturin July 2, 2024 17:06
@Artturin Artturin merged commit 1ded091 into NixOS:master Jul 2, 2024
24 checks passed
@jtojnar jtojnar mentioned this pull request Jul 2, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktBroich BenediktBroich BenediktBroich approved these changes

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robbins @BenediktBroich @shymega @Artturin