Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kubo: cleanup #280924

Merged
merged 1 commit into from
Jan 16, 2024
Merged

nixos/kubo: cleanup #280924

merged 1 commit into from
Jan 16, 2024

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jan 14, 2024

Description of changes

  • Add note explaining why enabling the Kubo daemon won't fully work immediately and requires logging in again
  • Use builtins.isList addrIn instead of builtins.typeOf addrIn == "list"
  • Fix indentation

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Luflosi
nixos/kubo: cleanup
a4c451f 
- Add note explaining why enabling the Kubo daemon won't fully work immediately and requires logging in again
- Use `builtins.isList addrIn` instead of `builtins.typeOf addrIn == "list"`
- Fix indentation
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 14, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 14, 2024
NickCao
NickCao approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM.

Unrelated question: what's WARNING: may cause severe network degradation about?

@NickCao NickCao merged commit 8161251 into NixOS:master Jan 16, 2024
22 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Merged
1 task
@Luflosi Luflosi deleted the kubo-cleanup branch January 16, 2024 16:17
@Luflosi
Copy link
Contributor Author

Luflosi commented Jan 16, 2024

Thanks!

Unrelated question: what's WARNING: may cause severe network degradation about?

Basically, Kubo may open very many TCP and QUIC/UDP connections, which may overwhelm the connection tracking table of consumer routers.
See ipfs/kubo#9998 and ipfs/kubo#3320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Luflosi @NickCao