Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hqplayer-desktop: 4.22.0-65 -> 5.8.2-25 #283631

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented Jan 25, 2024

Description of changes

https://signalyst.com/hqplayer-5-desktop-5-8-2-released/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 25, 2024
@ofborg ofborg bot requested a review from lovesegfault January 25, 2024 01:38
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 25, 2024
@ghost ghost mentioned this pull request Jan 25, 2024
13 tasks
@ghost ghost self-requested a review January 25, 2024 08:55
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will not start on my amd 5700x

[nix-shell:~/.cache/nixpkgs-review/pr-283631]$ ./results/hqplayer-desktop/bin/hqplayer5desktop 

Please verify that both the operating system and the processor support Intel(R) X87, CMOV, MMX, SSE, SSE2, SSE3, SSSE3, SSE4_1, SSE4_2 and POPCNT instructions.

@wegank
Copy link
Member Author

wegank commented Jan 25, 2024

Let's get #283681 in then.

@wegank wegank marked this pull request as draft January 25, 2024 08:58
@ghost
Copy link

ghost commented Jan 25, 2024

missing sse3.

processor       : 15
vendor_id       : AuthenticAMD
cpu family      : 25
model           : 33
model name      : AMD Ryzen 7 5700X 8-Core Processor
stepping        : 2
microcode       : 0xa20120a
cpu MHz         : 4154.787
cache size      : 512 KB
physical id     : 0
siblings        : 16
core id         : 7
cpu cores       : 8
apicid          : 15
initial apicid  : 15
fpu             : yes
fpu_exception   : yes
cpuid level     : 16
wp              : yes
flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoinvd arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl umip pku ospke vaes vpclmulqdq rdpid overflow_recov succor smca fsrm
bugs            : sysret_ss_attrs spectre_v1 spectre_v2 spec_store_bypass srso
bogomips        : 6800.43
TLB size        : 2560 4K pages
clflush size    : 64
cache_alignment : 64
address sizes   : 48 bits physical, 48 bits virtual
power management: ts ttp tm hwpstate cpb eff_freq_ro [13] [14]

@wegank wegank force-pushed the hqplayer-desktop-bump branch from b3b9019 to 8c96994 Compare January 27, 2024 17:38
@anttisoikkeli
Copy link

Btw as this hasn't been merged yet, wanted to comment that 5.6.1 has also been released. Unless it's more work than changing few lines, it would likely be better to update directly to that.

@wegank wegank force-pushed the hqplayer-desktop-bump branch from 8c96994 to 839a0d0 Compare November 2, 2024 00:41
@wegank wegank changed the title hqplayer-desktop: 4.22.0-65 -> 5.4.0-10 hqplayer-desktop: 4.22.0-65 -> 5.8.2-25 Nov 2, 2024
@wegank wegank force-pushed the hqplayer-desktop-bump branch from 839a0d0 to 3bd7f45 Compare November 2, 2024 00:44
@wegank wegank marked this pull request as ready for review November 2, 2024 20:41
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@wegank wegank force-pushed the hqplayer-desktop-bump branch from 3bd7f45 to cc19928 Compare November 10, 2024 03:13
@wegank wegank removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@wegank wegank force-pushed the hqplayer-desktop-bump branch from cc19928 to 73da872 Compare November 19, 2024 23:44
@wegank
Copy link
Member Author

wegank commented Nov 25, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 283631


x86_64-linux

✅ 2 packages built:
  • hqplayer-desktop
  • hqplayer-desktop.doc

@wegank
Copy link
Member Author

wegank commented Nov 26, 2024

hqplayer-desktop is 404 on master, merging so we have at least one working on Intel platforms...

@wegank wegank merged commit ef93532 into NixOS:master Nov 26, 2024
27 of 28 checks passed
@wegank wegank deleted the hqplayer-desktop-bump branch November 26, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants