Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.llvm-hs: unpin llvm_9 #284315

Merged
merged 1 commit into from Jan 28, 2024
Merged

haskellPackages.llvm-hs: unpin llvm_9 #284315

merged 1 commit into from Jan 28, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2024

according to https://hydra.nixos.org/build/233205149 the first broken build of llvm-hs was in 2022-02-18 09:30:43. unpin llvm_9 so LLVM9 can be removed from nixpkgsj.

if needed llvm-hs can be updated to a version that uses a newer llvm
https://github.com/llvm-hs/llvm-hs/#building-from-source

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

according  https://hydra.nixos.org/build/233205149 the first broken
build of llvm-hs was in 2022-02-18 09:30:43. unpin llvm_9 so LLVM9 can
be removed from nixpkgs
@ghost ghost mentioned this pull request Jan 27, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 27, 2024
@maralorn
Copy link
Member

Makes sense. Thank you for cleaning up.

@maralorn maralorn merged commit b279203 into NixOS:master Jan 28, 2024
26 checks passed
@ghost ghost deleted the unpin-llvm-9 branch January 29, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant