Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped tectonic version to 0.15.0 #286505

Conversation

Mastermindaxe
Copy link
Contributor

@Mastermindaxe Mastermindaxe commented Feb 5, 2024

Description of changes

Release for 0.15.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mastermindaxe
Copy link
Contributor Author

I just saw that the package had been updated and thought I'd make a quick PR. Sorry if I missed sth. Hacked this together in my lunch break.

Pinging you guys as you're the maintainers
@lluchs @doronbehar @bryango

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Feb 5, 2024
@ofborg ofborg bot requested review from lluchs, bryango and doronbehar February 5, 2024 15:35
@bryango
Copy link
Member

bryango commented Feb 5, 2024

Hi Mastermindaxe! Thank you very much for the PR! The changes look good to me! I do have some nitpicks: please rephrase the PR title and commit message according to the convention: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions. In this case, it would be something like:

tectonic-unwrapped,tectonic: 0.14.1 -> 0.15.0

Release notes: https://github.com/tectonic-typesetting/tectonic/releases/tag/tectonic%400.15.0

I will do some more serious testing as soon as possible!

@doronbehar
Copy link
Contributor

@bryango now is the opportunity to use --add-flags in the wrapper. And yes, @Mastermindaxe you may like nix-update --commit to perform such simple version bumps.

@Mastermindaxe Mastermindaxe force-pushed the update_tectonic_version_to_0.15.0 branch from cadfa57 to b2091ed Compare February 5, 2024 15:46
@doronbehar
Copy link
Contributor

This commit message, won't trigger CI automatically:

tectonic-unwrapped, tectonic: 0.14.1 -> 0.15.0

OTH this would:

tectonic: 0.14.1 -> 0.15.0

@Mastermindaxe
Copy link
Contributor Author

This commit message, won't trigger CI automatically:

tectonic-unwrapped, tectonic: 0.14.1 -> 0.15.0

OTH this would:

tectonic: 0.14.1 -> 0.15.0

Oh okay! I'll change it then to tectonic: ...

Thank you guys for the quick feedback! Much appreciated

@Mastermindaxe Mastermindaxe force-pushed the update_tectonic_version_to_0.15.0 branch from b2091ed to 712b827 Compare February 5, 2024 15:50
Copy link
Member

@bryango bryango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy; binary manually tested, LGTM!

Result of nixpkgs-review pr 286505 run on x86_64-linux

2 packages built:
  • tectonic
  • tectonic-unwrapped

Result of nixpkgs-review pr 286505 run on x86_64-darwin

2 packages built:
  • tectonic
  • tectonic-unwrapped

now is the opportunity to use --add-flags in the wrapper.

@doronbehar A subsequent PR #286615 is based on this one, which wraps tectonic with a locked web bundle to ensure reproducibility & compatibility with biber 🎉

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Feb 6, 2024
@doronbehar
Copy link
Contributor

Thanks all for your work :). I'm closing this one in favor of #286615

@doronbehar doronbehar closed this Feb 6, 2024
@bryango
Copy link
Member

bryango commented Feb 6, 2024

Thank you for your contributions! I will make sure your credits are preserved in #286615!

Update: @Mastermindaxe your patch has been merged! You should now see a Contributor badge. Congrats! 🎉

@Mastermindaxe
Copy link
Contributor Author

@bryango Cheers! Still amazed how fast you guys responded 😄 Have a good one!

@Mastermindaxe Mastermindaxe deleted the update_tectonic_version_to_0.15.0 branch February 6, 2024 09:31
@Mastermindaxe Mastermindaxe restored the update_tectonic_version_to_0.15.0 branch February 9, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants