-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped tectonic version to 0.15.0 #286505
Bumped tectonic version to 0.15.0 #286505
Conversation
I just saw that the package had been updated and thought I'd make a quick PR. Sorry if I missed sth. Hacked this together in my lunch break. Pinging you guys as you're the maintainers |
Hi Mastermindaxe! Thank you very much for the PR! The changes look good to me! I do have some nitpicks: please rephrase the PR title and commit message according to the convention: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions. In this case, it would be something like:
I will do some more serious testing as soon as possible! |
@bryango now is the opportunity to use |
cadfa57
to
b2091ed
Compare
This commit message, won't trigger CI automatically:
OTH this would:
|
Oh okay! I'll change it then to Thank you guys for the quick feedback! Much appreciated |
b2091ed
to
712b827
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixpkgs-review
happy; binary manually tested, LGTM!
Result of nixpkgs-review pr 286505
run on x86_64-linux
2 packages built:
- tectonic
- tectonic-unwrapped
Result of nixpkgs-review pr 286505
run on x86_64-darwin
2 packages built:
- tectonic
- tectonic-unwrapped
now is the opportunity to use
--add-flags
in the wrapper.
@doronbehar A subsequent PR #286615 is based on this one, which wraps tectonic with a locked web bundle to ensure reproducibility & compatibility with biber 🎉
Thanks all for your work :). I'm closing this one in favor of #286615 |
Thank you for your contributions! I will make sure your credits are preserved in #286615! Update: @Mastermindaxe your patch has been merged! You should now see a Contributor badge. Congrats! 🎉 |
@bryango Cheers! Still amazed how fast you guys responded 😄 Have a good one! |
Description of changes
Release for 0.15.0
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.