nixos/bash-completion: add completion.package option, drop with lib #291552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
ncfavier
reviewed
Apr 10, 2024
wegank
added
the
2.status: merge conflict
SuperSandro2000
force-pushed
the
bash-completion-package-option
branch
from
55372ee
to
b6a8231
Compare
SuperSandro2000
changed the title
SuperSandro2000
force-pushed
the
bash-completion-package-option
branch
2 times, most recently
from
b0c8d14
to
6705659
Compare
ofborg
bot
removed
the
2.status: merge conflict
SuperSandro2000
force-pushed
the
bash-completion-package-option
branch
from
6705659
to
cbcddc0
Compare
|
Tested this with #310322 and works great. |
SuperSandro2000
force-pushed
the
bash-completion-package-option
branch
from
cbcddc0
to
fc0195d
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
…package option, drop with lib This allows to easily test bash-completion updates without triggering a mass rebuild locally.
SuperSandro2000
force-pushed
the
bash-completion-package-option
branch
from
fc0195d
to
1c60f0a
Compare
ofborg
bot
added
10.rebuild-darwin: 0
isabelroses
added a commit
to isabelroses/nix-darwin
that referenced
this pull request
Sep 30, 2024
a port of NixOS/nixpkgs#291552 for darwin
isabelroses
added a commit
to isabelroses/nix-darwin
that referenced
this pull request
Oct 8, 2024
a port of NixOS/nixpkgs#291552 for darwin
arulagrawal
added a commit
to arulagrawal/nix-darwin
that referenced
this pull request
Oct 22, 2024
* fix: initdb missing data area directory Use `PGDATA` environment variable instead of `-D` to maintain consistency with NixOS module. Co-Authored-By: Michael Hoang <enzime@users.noreply.github.com> * Use the correct file location for `SoftwareUpdate` plist. * flake: match NixOS definition of `nixpkgs.flake.source` Closes: LnL7#1082 * feat: use wait4path with script launchd option addresses LnL7#1043 fix: use exec in launchd daemon config fix: dont use a script thats in the nix store fix: remove manual wait4path in linux-builder fix: remove manual wait4path in karabiner elements fix: remove manual wait4path in nix-daemon fix: remove manual wait4path in nix-optimise fix: remove manual wait4path in tailscaled fix: autossh test Revert "fix: remove manual wait4path in nix-daemon" This reverts commit 6aec084. fix: remove bad exec Reapply "fix: remove manual wait4path in nix-daemon" This reverts commit c8f136e. fix: update autossh test to reflect changes in f86e613 fix: services-activate-system-changed-label-prefix test fix: services-buildkite-agent test fix: services-activate-system test fix: escape ampersand fix: services-lorri test fix: services-nix-optimise test fix: services-nix-gc test refactor: use script rather than command in daemon fix: use config.command for clarity style: fix indentation fix: use lib.getExe rather than directly pointing to file revert: a87fc7b - mistaken refactor meant that service waited for nix store and not the relevant path * fix: karabiner elements virtualhiddeviceclient - command needed to be quoted * Adding option for slow-motion-allowed; This was inspired by a recent Daring Fireball post where I was reminded about this feature and how it's missing from being able to configure it in Nix-Darwin. [https://daringfireball.net/linked/2024/09/28/hidden-pref-to-restore-slow-motion-dock-minimizing-on-macos]() * fix: remove deprecated lib.mdDoc * add JankyBorders option order and set below by default (values: above/below) * Update modules/services/jankyborders/default.nix Co-authored-by: Michael Hoang <Enzime@users.noreply.github.com> * push change to jankyborders test * netdata: add netdata service in nix-darwin. * programs/bash: move to completion.* a port of NixOS/nixpkgs#291552 for darwin * defaults: don't output Dock PID * skhd: add `skhd` to `PATH` * ci: don't run tests twice for PRs from forks By only triggering on pushes to `master`, when users push to non-`master` branches on forks, this workflow won't get triggered and will only get triggered when users make a PR to the main repo. * ci: update Nix to match versions in nixpkgs --------- Co-authored-by: Francesc Esplugas <2720+fesplugas@users.noreply.github.com> Co-authored-by: Michael Hoang <enzime@users.noreply.github.com> Co-authored-by: Mike Moore <emmceemoore@gmail.com> Co-authored-by: Emily <vcs@emily.moe> Co-authored-by: will <will.bradshaw50@gmail.com> Co-authored-by: Roger Steve Ruiz <hi@rog.gr> Co-authored-by: isabel <isabel@isabelroses.com> Co-authored-by: aspauldingcode <aspauldingcode@gmail.com> Co-authored-by: Rohit Singh <rsrohitsingh682@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to easily test bash-completion updates without triggering a mass rebuild locally.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.