Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musescore: Remove 'broken' for aarch64-linux. #292930

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

simonhollingshead
Copy link
Contributor

@simonhollingshead simonhollingshead commented Mar 3, 2024

Description of changes

The justification for marking this package as broken on ARM (in the comment which is being removed at the same time) is that there is a compile-time issue.

It looks like the issue being referred to is musescore/MuseScore#18353.

This was already fixed in musescore/MuseScore#18575.

I can confirm that musescore on aarch64-linux builds just fine on my ARM machine. The compile completed with no issue, and the main program launched and responded just fine.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@simonhollingshead simonhollingshead marked this pull request as ready for review March 3, 2024 02:02
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 3, 2024
@simonhollingshead simonhollingshead marked this pull request as draft March 3, 2024 03:16
@simonhollingshead simonhollingshead changed the base branch from master to staging March 3, 2024 03:19
@simonhollingshead simonhollingshead marked this pull request as ready for review March 3, 2024 03:20
@drupol
Copy link
Contributor

drupol commented Mar 4, 2024

@ofborg build musescore

@simonhollingshead simonhollingshead marked this pull request as draft March 10, 2024 17:44
@simonhollingshead simonhollingshead changed the base branch from staging to master March 10, 2024 17:47
@simonhollingshead simonhollingshead marked this pull request as ready for review March 10, 2024 17:48
@Artturin Artturin merged commit 643436f into NixOS:master Mar 11, 2024
40 checks passed
@simonhollingshead simonhollingshead deleted the musescore-arm branch March 11, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants