Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs/{by-name,development}: remove unused fetchpatch (and other) arguments #314137

Merged

Conversation

Sigmanificient
Copy link
Member

Description of changes

This is a follow-up pr from the previous cleanup pr, since it did well:

I continued remove unused fetchpatch arguments, targeting the ones remaining from pkgs/development and thoses from pkgs/by-name.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient force-pushed the remove-fetchpatch-pkgs-development-2 branch from 9d0ceda to 519c3c4 Compare May 24, 2024 00:51
@Sigmanificient Sigmanificient force-pushed the remove-fetchpatch-pkgs-development-2 branch from 519c3c4 to 203a48a Compare May 24, 2024 00:54
@Sigmanificient Sigmanificient changed the title pkgs/development: remove unused fetchpatch arguments pkgs/{by-name,development}: remove unused fetchpatch (and other) arguments May 24, 2024
@Sigmanificient
Copy link
Member Author

Sigmanificient commented May 24, 2024

Oh wow the bot asked many reviwers 😅

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 24, 2024
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

Copy link
Member

@kirillrdy kirillrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zero rebuilds

@drupol drupol merged commit 5dd16b4 into NixOS:master May 24, 2024
23 checks passed
@Sigmanificient Sigmanificient deleted the remove-fetchpatch-pkgs-development-2 branch May 24, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: haskell 6.topic: lua 6.topic: nodejs 6.topic: ocaml 6.topic: php 6.topic: ruby 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants