Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove unused occurence of stdenv (and other) arguments #324767

Merged
merged 1 commit into from
Jul 14, 2024
Merged

treewide: remove unused occurence of stdenv (and other) arguments #324767

merged 1 commit into from
Jul 14, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: qt/kde 6.topic: ocaml 6.topic: dotnet Language: .NET labels Jul 5, 2024
@Sigmanificient Sigmanificient force-pushed the remove-unused-stdenv-arguments branch from 21d9b3e to a658117 Compare July 5, 2024 08:23
@Sigmanificient Sigmanificient force-pushed the remove-unused-stdenv-arguments branch 3 times, most recently from 6f7ae7c to 9a33f9a Compare July 5, 2024 08:31
@Sigmanificient Sigmanificient changed the title treewide: remove unused occurence of stdenv (and other) arguements treewide: remove unused occurence of stdenv (and other) arguments Jul 5, 2024
@Sigmanificient Sigmanificient force-pushed the remove-unused-stdenv-arguments branch from 9a33f9a to d8ab548 Compare July 5, 2024 08:41
@mweinelt mweinelt marked this pull request as draft July 5, 2024 09:51
@mweinelt
Copy link
Member

mweinelt commented Jul 5, 2024

@corngood Are you aware that this PR breaks eval?

@corngood
Copy link
Contributor

corngood commented Jul 5, 2024 •
edited
Loading

Sorry, I realised that after I submitted my review. I just wanted to indicate that I'm okay with the changes to the packages I maintain. I removed it.

@corngood corngood self-requested a review July 5, 2024 15:39
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jul 5, 2024 •
edited
Loading

Not sure why some problematic ones were not catchd by nixpkgs-review, maybe i ran it in the wrong branch?
Thanks for setting it in draft btw

@Sigmanificient Sigmanificient force-pushed the remove-unused-stdenv-arguments branch 2 times, most recently from 231a254 to 7431f19 Compare July 5, 2024 15:58
@Sigmanificient Sigmanificient force-pushed the remove-unused-stdenv-arguments branch 2 times, most recently from 683b64f to dbfa800 Compare July 5, 2024 16:14
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 5, 2024
@Sigmanificient Sigmanificient marked this pull request as ready for review July 8, 2024 17:55
@Sigmanificient
Copy link
Member Author

Result of nixpkgs-review pr 324767 run on x86_64-linux 1

@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jul 8, 2024 •
edited
Loading

(Nothing to be built. 🎉)

@Sigmanificient Sigmanificient force-pushed the remove-unused-stdenv-arguments branch 3 times, most recently from 14f161c to 66f46bb Compare July 12, 2024 20:40
@Sigmanificient
Copy link
Member Author

Can we gets this merged before more conflicts needs to be sorted?

@mweinelt
Copy link
Member

Please remove the merge commit.

@Sigmanificient Sigmanificient force-pushed the remove-unused-stdenv-arguments branch from 2792dca to c8427f5 Compare July 13, 2024 23:06
@Sigmanificient
Copy link
Member Author

@mweinelt done

@tomberek
Copy link
Contributor

Due to https://github.com/NixOS/nixpkgs/blob/c8427f5017070086009c975f30b7a487e73502c0/pkgs/development/python-modules/pillow/generic.nix#L12 the default.nix needs stdenv.

@Sigmanificient Sigmanificient force-pushed the remove-unused-stdenv-arguments branch 2 times, most recently from e4447a6 to 6d98514 Compare July 14, 2024 01:53
@Sigmanificient Sigmanificient force-pushed the remove-unused-stdenv-arguments branch from 6d98514 to 512e8af Compare July 14, 2024 02:33
@Aleksanaa Aleksanaa merged commit e8f2aab into NixOS:master Jul 14, 2024
21 checks passed
@Aleksanaa
Copy link
Member

@RossComputerGuy I saw you in my email here. Is that still related and should we deal with it immediately?

@RossComputerGuy
Copy link
Member

Is that still related and should we deal with it immediately?

No, it looked a lot like it was a regression but just an issue with a PR after I read more of the nix code which is why I deleted it.

@Sigmanificient Sigmanificient deleted the remove-unused-stdenv-arguments branch July 16, 2024 01:39
imincik added a commit to imincik/geospatial-nix that referenced this pull request Jul 18, 2024
@imincik
python3-owslib: remove unused occurence of stdenv (and other) arguments
027317f 
Nixpkgs PR:
NixOS/nixpkgs#324767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@corngood corngood corngood approved these changes

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

@jtojnar jtojnar Awaiting requested review from jtojnar

@K900 K900 Awaiting requested review from K900

@NickCao NickCao Awaiting requested review from NickCao

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@ttuegel ttuegel Awaiting requested review from ttuegel

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: python 6.topic: qt/kde 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Sigmanificient @mweinelt @corngood @tomberek @Aleksanaa @RossComputerGuy @nixos-discourse