Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove trailing space in description #330042

Merged
merged 1 commit into from
Jul 26, 2024
Merged

treewide: remove trailing space in description #330042

merged 1 commit into from
Jul 26, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: ocaml labels Jul 26, 2024
@Sigmanificient Sigmanificient force-pushed the remove-leading-space-description branch from 7339039 to 2154f87 Compare July 26, 2024 00:35
@Sigmanificient Sigmanificient changed the title treewide: remove leading space in description treewide: remove trailing space in description Jul 26, 2024
donovanglover
donovanglover approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

infinisil
infinisil approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Sigmanificient Sigmanificient added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jul 26, 2024
tomodachi94
tomodachi94 requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you post the code that you used to generate this, and amend your commit description to include the code?

@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jul 26, 2024 •
edited
Loading

Could you post the code that you used to generate this, and amend your commit description to include the code?

Hum I used grep -rP 'description\s+=\s+"[^"]+[ ]";' | cut -d ':' -f 1 | xargs -i nvim {} which opens a nvim instance for each match of the previous regex, then sorted them by hand, avoiding generated packages list

Should I amend with that command?

@tomodachi94
Copy link
Member

Could you post the code that you used to generate this, and amend your commit description to include the code?

Hum I used grep -rP 'description\s+=\s+"[^"]+[ ]";' | cut -d ':' -f 1 | xargs -i nvim {} which opens a nvim instance for each match of the previous regex, then sorted them by hand, avoiding generated packages list

Should I amend with that command?

Definitely. I was under the impression that this was a fully automatic change, but I was mistaken 😅

@Sigmanificient
treewide: remove trailing space in description
543cd40 
Done using `grep -rP 'description\s+=\s+"[^"]+[ ]";' | cut -d ':' -f 1 |
xargs -i nvim {}` and sorting the opened files by hand, avoiding
generated packages list
@Sigmanificient Sigmanificient force-pushed the remove-leading-space-description branch from 2154f87 to 543cd40 Compare July 26, 2024 01:38
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jul 26, 2024 •
edited
Loading

Would love to give same treatment with periods, but there is about 3800 of them 😅

grep -rP 'description\s+=\s+"[^"]+[.]";'

Should I do a tracking pr and do them block by block just like #313981?

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 26, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1858

@Sigmanificient Sigmanificient added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Jul 26, 2024
@jopejoe1
Copy link
Member

Thanks!

afh
afh suggested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the ending punctuation as recommended in https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#meta-attributes

tomodachi94
tomodachi94 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I think this can be merged as-is, as you've mentioned cleaning up the punctuation in another PR.

@Aleksanaa Aleksanaa merged commit 577a9c4 into NixOS:master Jul 26, 2024
26 checks passed
@Sigmanificient Sigmanificient deleted the remove-leading-space-description branch July 26, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afh afh afh requested changes

@tomodachi94 tomodachi94 tomodachi94 approved these changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@jopejoe1 jopejoe1 jopejoe1 approved these changes

@infinisil infinisil infinisil approved these changes

@Mindavi Mindavi Mindavi approved these changes

@donovanglover donovanglover donovanglover approved these changes

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Sigmanificient @tomodachi94 @nixos-discourse @jopejoe1 @afh @donovanglover @Mindavi @infinisil @Aleksanaa