Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv: fix nix develop #363672

Merged

Conversation

wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Dec 9, 2024

This was introduced in #360466.

See #360466 (comment) for details.

Still building everything to check this actually works.

@trofi

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This was introduced in NixOS#360466.
@wolfgangwalther
Copy link
Contributor Author

tests.stdenv are fine, nix develop -f. hello breaks before this commit and is fixed after. LGTM.

Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hacks on hacks, but we did pick Bash as the language de guerre for stdenv. @Ma27 @wolfgangwalther do you think there's something we could do in Nix itself to make the original version work?

@Mic92 Mic92 merged commit 4fae212 into NixOS:staging Dec 9, 2024
25 of 26 checks passed
@Mic92
Copy link
Member

Mic92 commented Dec 9, 2024

@philiptaron NixOS/nix#11921

@roberth
Copy link
Member

roberth commented Dec 9, 2024

Reminds me that the nix develop/stdenv coupling is Very Bad.

(simplest root cause was NixOS/nix#11921, fwiw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants