Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/types: Introduce lazyAttrsOf #70138

Merged
merged 6 commits into from
Jan 10, 2020
Merged

lib/types: Introduce lazyAttrsOf #70138

merged 6 commits into from
Jan 10, 2020

Commits on Jan 10, 2020

  1. lib/modules: Move the isDefined check into mergedValue 

    Without this change, accessing `mergedValue` from `mergeDefinitions` in
case there are no definitions will throw an error like

  error: evaluation aborted with the following error message: 'This case should never happen.'

This change makes it throw the appropriate error

  error: The option `foo' is used but not defined.

This is fully backwards compatible.
    @infinisil
    infinisil committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    130a0c9 View commit details
    Browse the repository at this point in the history

  2. nixos/doc: Note that attrsOf is strict in its values

    @infinisil
    infinisil committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    d5a2922 View commit details
    Browse the repository at this point in the history

  3. lib/types: Add emptyValue attribute to types 

    Co-Authored-By: Robert Hensing <roberth@users.noreply.github.com>
    @infinisil @roberth
    infinisil and roberth committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    4268b4f View commit details
    Browse the repository at this point in the history

  4. lib/types: Introduce lazyAttrsOf 

    The standard attrsOf is strict in its *values*, meaning it's impossible to
access only one attribute value without evaluating all others as well.
lazyAttrsOf is a version that doesn't have that problem, at the expense
of conditional definitions not properly working anymore.
    @infinisil
    infinisil committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    b48717d View commit details
    Browse the repository at this point in the history

  5. lib/tests: Add tests for attrsOf and lazyAttrsOf

    @infinisil
    infinisil committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    ab10e87 View commit details
    Browse the repository at this point in the history

  6. lib/modules: Switch _module.args from attrsOf to lazyAttrsOf

    @infinisil
    infinisil committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    9e97e64 View commit details
    Browse the repository at this point in the history