-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubyPackages: remove global v8 pinning #72419
rubyPackages: remove global v8 pinning #72419
Conversation
Removes global pinning of v8 to 3.16.14 and also removes the unreferenced package 'therubyracer'.
Very nice! Can we also update meta for the v8_3* packages, so it's clear they don't work on aarch64?
|
@flokli I agree. At least for 3.14 it seems to much of a hassle to get it to build on aarch64 and we can now even remove 3.16.14, because no other package references it after the removal of |
We should probably backport the ruby v8 change (or something only applying for gitlab, don't know what could break) into 19.09, to fix GitLab there on aarch64, too. |
therubyracer may not be referenced elsewhere, but it’s used by a large number of Rails applications — I suspect everybody using NixOS to do Rails development would complain if we dropped build support for it. |
source: https://rubygems.org/gems/therubyracer Looking at the repo is doesn't seem maintained anymore. The last release was in January 2017. |
Looking at the repo is doesn't seem maintained anymore. The last
release was in January 2017.
Ah, didn't realise that. I guess we've moved on.
In that case, dropping is fine with me.
|
I remember that |
Ah I noticed that the project seemed to be no longer maintained. Sorry for not mentioning it above :/ |
Motivation for this change
The motivation behind this is the failing build of
v8_3_16_14
on aarch64-linux, which causes gitlab to fail (#68550 (comment)) because it depends on ruby packages that depend on the broken v8 version because of an old version pinning.The only ruby package that does not build with the latest v8 is
therubyracer
and it is not referenced by any other expression.This removes the global pinning of v8 to 3.16.14 and also removes the
unreferenced package 'therubyracer'.
edit: This now also removes the no longer referenced v8 version 3.16.14 and limits the supported platforms of v8 version 3.14 to x86_*-linux
Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandbox
innix.conf
on non-NixOS linux)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested execution of all binary files (usually in
./result/bin/
)Determined the impact on package closure size (by running
nix path-info -S
before and after)Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.
Successfully ran nix-review:
Result of
nix-review
15 package were build:
ping @flokli