Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] openssl_1_0_2: mark as insecure; fixes #77503 (kinda) #81718

Merged
merged 1 commit into from
Mar 5, 2020
Merged

[20.03] openssl_1_0_2: mark as insecure; fixes #77503 (kinda) #81718

merged 1 commit into from
Mar 5, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Backports #80746.
It's close to a week since it was merged, so I think we have enough fixes for a backport (though not everything is fixed, but that wasn't the largest requirement)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat @worldofpeace
openssl_1_0_2: mark as insecure; fixes NixOS#77503 (kinda)
7dfb444 
No vulnerabilities are know so far (to me), but still I'd go this way.
Especially for 20.03 it seems better to deprecate it before official
release happens.

Current casualties:
$ ./maintainers/scripts/rebuild-amount.sh --print HEAD HEAD^
Estimating rebuild amount by counting changed Hydra jobs.
     87 x86_64-darwin
    161 x86_64-linux

(cherry picked from commit 7cda282)
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 4, 2020
vcunat
vcunat approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those fixes for master should already all be in 20.03, right?

@worldofpeace
Copy link
Contributor Author

Those fixes for master should already all be in 20.03, right?

Yep, I believe every one that referenced it was backported.

@worldofpeace worldofpeace merged commit 1f99fd2 into NixOS:release-20.03 Mar 5, 2020
@worldofpeace worldofpeace deleted the backport-80746 branch March 5, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worldofpeace @vcunat