-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdenv/darwin: put compiler-rt into bootstrap tarball #94426
stdenv/darwin: put compiler-rt into bootstrap tarball #94426
Conversation
compiler-rt is no longer included in clang, so the current result of building bootstrap tools doesn't include compiler-rt at all.
The main problem I'm seeing with trying to update the bootstrap tools without both of these changes is
Full log: https://gist.github.com/thefloweringash/10f236a3d9fee59298bdee2ec47480e8 The curl with the undefined
|
Quick sanity check: libclang_rt differences from current bootstrap tools to currently generated bootstrap tools
libclang_rt differences from currently generated bootstrap tools (
|
/cc @LnL7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned this before on irc, but I think this is more of a bootstrapping issue. Keeping as much as possible out of the bootstrap tarball makes bootstrapping more flexible and simplifies introducing a new architecture.
All that said I don't see a particularly big problem with adding compiler-rt.
As I understand it,
Not sure if I made this clear, but the current bootstrap tools contain compiler-rt. I think it was removed from the generator by #39743 as part of a clang refactoring. This change is to intended to keep the structure of the current bootstrap tools. |
What is the status of the PR? I'm not an expert in this area, but the change (including more of the already build llvmPackages code) doesn't seem like it can introduce issues (except for increasing the surface area of the bootstrap tarball), so I think it's worth including as it solves real issues. |
@ofborg eval |
This was subsumed by bootstrap changes in #105026. |
compiler-rt is no longer included in clang, so the current result of
building bootstrap tools doesn't include compiler-rt at all.
Motivation for this change
I want to update bootstrap tools soon as part of #19906, but just doing the update results in a subtly broken early toolchain. It looks like the bootstrap tools builder needs a small update. This is the first part that puts the required parts into the tarball, there's a follow up that fixes the unpacking stage.
This defines a new set of bootstrap tools, see #94427 for the "other half" that uses the updated bootstrap tools.
Possibly related #39743
cc @matthewbauer and @LnL7 who seem to work on the bootstrap files
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)