Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project creation file management #3269

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Oct 12, 2022

Fixes problems with project creation (#3200 , #3240) by adding a list of files that should not be copied over from the sample project, and another list of files that should not be overwritten if they already exist. Didn't see any tests related to project creation so did not include any for this.

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Closes: #3200, #3240

Closes: NomicFoundation#3200, NomicFoundation#3240
Signed-off-by: Tomás Migone <tomasmigone@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

⚠️ No Changeset found

Latest commit: e834c8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hardhat ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 8:05PM (UTC)
hardhat-storybook ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 8:05PM (UTC)

@github-actions
Copy link
Contributor

This issue is also being tracked on Linear.

We use Linear to manage our development process, but we keep the conversations on Github.

LINEAR-ID: 30e79627-4aff-46f8-be35-58216b27dc05

@alcuadrado
Copy link
Member

Sorry we took so long to reply, and thanks for submitting this issue.

This was already fixed in #3211

@alcuadrado alcuadrado closed this Feb 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

We couldn't initialize the sample project because this file already exists ERROR
4 participants