Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure selection options for sinking speed and aggregation? #421

Closed
TomasTorsvik opened this issue Oct 24, 2024 · 2 comments
Closed
Assignees
Labels
iHAMOCC Issue mainly concerns the iHAMOCC code base

Comments

@TomasTorsvik
Copy link
Contributor

TomasTorsvik commented Oct 24, 2024

I wonder if it would make sense to restructure the way we select options for sinking speed and aggregation.

At the moment we have three logical switches USE_WLIN, USE_AGG and USE_M4AGO, of which only one should be .true., i.e. 4 options if we include the option that all of these are .false.. We trust the user to know that only one of these options should be applied at a time, and I don't think we do much testing to see if this the case.

I propose to replace these logical switches with a string variable that can take values "WLIN", "AGG", "M4AGO" or "default" (i.e. if none of the first three applies). This would make it easier to control that only one sinking algorithm is applied. Does this make sense to you? Are there any pitfalls you foresee in implementing such a solution?

@TomasTorsvik TomasTorsvik added the iHAMOCC Issue mainly concerns the iHAMOCC code base label Oct 24, 2024
@jmaerz
Copy link
Collaborator

jmaerz commented Oct 24, 2024

As briefly discussed, I'll give it a try in #420 .

@jmaerz
Copy link
Collaborator

jmaerz commented Oct 24, 2024

With PR #420 , I think this can be closed. Otherwise, feel free to re-open the issue.

@jmaerz jmaerz closed this as completed Oct 24, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in NorESM Development Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
Status: Done
Development

No branches or pull requests

3 participants