From 5c8d15562115fff2ae0d80ccfbb03188e038ee37 Mon Sep 17 00:00:00 2001 From: tveten Date: Wed, 11 Dec 2024 23:10:26 +0100 Subject: [PATCH 1/4] add support for python 3.13 in pyproject.toml --- pyproject.toml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index cd217d2..ba66a21 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -28,12 +28,15 @@ classifiers = [ "Operating System :: POSIX", "Operating System :: Unix", "Operating System :: MacOS", + "Programming Language :: Python :: 3 :: Only", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", "Programming Language :: Python :: 3.12", + "Programming Language :: Python :: 3.12", + "Programming Language :: Python :: 3.13", ] -requires-python = ">=3.9,<3.13" +requires-python = ">=3.9,<3.14" dependencies = [ "numpy>=1.21", "pandas>=1.1", @@ -52,7 +55,7 @@ numba = [ # all_extras - all soft dependencies, install via "pip install skchange[all_extras]" all_extras = [ "optuna>=3.1.1", - "plotly>=5.13.0", + "plotly>=5.13.0; python_version < '3.13'", "numba>=0.56", ] From 2eb60ac213901255313e11c90a8bc701d856487a Mon Sep 17 00:00:00 2001 From: tveten Date: Wed, 11 Dec 2024 23:11:09 +0100 Subject: [PATCH 2/4] remove unused soft dependences optuna and plotly only used in dev parts of the code --- pyproject.toml | 2 -- 1 file changed, 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index ba66a21..4475f4d 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -54,8 +54,6 @@ numba = [ # all_extras - all soft dependencies, install via "pip install skchange[all_extras]" all_extras = [ - "optuna>=3.1.1", - "plotly>=5.13.0; python_version < '3.13'", "numba>=0.56", ] From e5218bd322c632a34149c805a94646bae3f7b25b Mon Sep 17 00:00:00 2001 From: tveten Date: Wed, 11 Dec 2024 23:12:21 +0100 Subject: [PATCH 3/4] require sktime >= 0.35 Contains upagraded functionality for detectors. --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 4475f4d..cd9cd57 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -40,7 +40,7 @@ requires-python = ">=3.9,<3.14" dependencies = [ "numpy>=1.21", "pandas>=1.1", - "sktime>=0.33", + "sktime>=0.35", ] [project.urls] From 54ebd2eee35a3aa55158df45c494aba83be9760d Mon Sep 17 00:00:00 2001 From: tveten Date: Wed, 11 Dec 2024 23:19:29 +0100 Subject: [PATCH 4/4] ci: run tests for both python 3.9 and 3.13 --- .github/workflows/tests.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index b80fc1f..79a1abf 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -24,13 +24,19 @@ jobs: pytests-without-numba: name: pytests-without-numba + strategy: + fail-fast: false + matrix: + python-version: + - "3.9" + - "3.13" runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - name: Set up Python uses: actions/setup-python@v5 with: - python-version: "3.9" + python-version: ${{ matrix.python-version }} - name: Run skchange without Numba run: | python -m pip install --upgrade pip @@ -53,7 +59,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v5 with: - python-version: "3.9" + python-version: ${{ matrix.python-version }} - name: Run skchange with and without Numba # Both with and without to get full coverage report. # Without numba is very fast, so it doesn't hurt to run it twice.