Merge pull request #1550 from NoxOrg/feature/NOX-1034 #3768
ggrgovskiAnnotations
10 errors and 11 warnings
|
build (8.x):
src/Nox.Yaml/Serialization/VariablesDeserializer.cs#L7
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
|
|
build (8.x):
src/Nox.Yaml/Schema/Generator/SchemaGenerator.cs#L10
Define a constant instead of using this literal 'array' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
build (8.x):
src/Nox.Yaml/Constants/Constants.cs#L3
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
|
|
build (8.x):
src/Nox.Yaml/Schema/Generator/SchemaProperty.cs#L338
Define a constant instead of using this literal 'string' 7 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
build (8.x):
src/Nox.Yaml/Exceptions/NoxYamlException.cs#L6
Make this exception 'public'. (https://rules.sonarsource.com/csharp/RSPEC-3871)
|
|
build (8.x):
src/Nox.Yaml/Exceptions/NoxYamlException.cs#L18
Make sure not performing data validation after deserialization is safe here. (https://rules.sonarsource.com/csharp/RSPEC-5766)
|
|
build (8.x):
src/Nox.Yaml/Exceptions/NoxYamlException.cs#L37
Make sure not performing data validation after deserialization is safe here. (https://rules.sonarsource.com/csharp/RSPEC-5766)
|
|
build (8.x):
src/Nox.Yaml/Exceptions/NoxYamlException.cs#L26
Remove this empty statement. (https://rules.sonarsource.com/csharp/RSPEC-1116)
|
|
build (8.x):
src/Nox.Yaml/Exceptions/NoxYamlException.cs#L45
Remove this empty statement. (https://rules.sonarsource.com/csharp/RSPEC-1116)
|
|
build (8.x):
src/Nox.Yaml/Extensions/TypeExtensions.cs#L62
Collection-specific "Exists" method should be used instead of the "Any" extension. (https://rules.sonarsource.com/csharp/RSPEC-6605)
|
|
build (8.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-java@v3, actions/setup-dotnet@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build (8.x):
src/Nox.Yaml/Serialization/VariablesDeserializer.cs#L7
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
|
|
build (8.x):
src/Nox.Yaml/Constants/Constants.cs#L3
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
|
|
build (8.x):
src/Nox.Yaml/Exceptions/NoxYamlException.cs#L6
Make this exception 'public'. (https://rules.sonarsource.com/csharp/RSPEC-3871)
|
|
build (8.x):
src/Nox.Yaml/Exceptions/NoxYamlException.cs#L18
Make sure not performing data validation after deserialization is safe here. (https://rules.sonarsource.com/csharp/RSPEC-5766)
|
|
build (8.x):
src/Nox.Yaml/Exceptions/NoxYamlException.cs#L37
Make sure not performing data validation after deserialization is safe here. (https://rules.sonarsource.com/csharp/RSPEC-5766)
|
|
build (8.x):
src/Nox.Yaml/Schema/Generator/SchemaGenerator.cs#L10
Define a constant instead of using this literal 'array' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
build (8.x):
src/Nox.Yaml/Schema/Generator/SchemaProperty.cs#L338
Define a constant instead of using this literal 'string' 7 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
build (8.x):
src/Nox.Yaml/Parser/ReadOnlyCollectionNodeTypeResolver.cs#L8
Rename parameter 'type' to 'currentType' to match the interface declaration. (https://rules.sonarsource.com/csharp/RSPEC-927)
|
|
build (8.x):
src/Nox.Yaml/Parser/YamlWithLineInfoParser.cs#L16
Refactor this method to reduce its Cognitive Complexity from 44 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
|
|
build (8.x):
src/Nox.Yaml/Parser/YamlWithLineInfoParser.cs#L31
'System.Exception' should not be thrown by user code. (https://rules.sonarsource.com/csharp/RSPEC-112)
|