Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository/commit attribute to nuspec format #6547

Closed
emgarten opened this issue Feb 8, 2018 · 5 comments
Closed

Add repository/commit attribute to nuspec format #6547

emgarten opened this issue Feb 8, 2018 · 5 comments
Labels
Functionality:Pack Priority:1 High priority issues that must be resolved in the current sprint.
Milestone

Comments

@emgarten
Copy link
Member

emgarten commented Feb 8, 2018

Nuspecs currently include repository type and url, this should be extended to include the commit hash.

Example:

    <repository type="git"
               url="https://github.com/NuGet/NuGet.Client"
               commit="17caacc71d2cfa40f6ce10d4f0bbec8ea68f4cda" />

Pack should be updated to allow passing this in from a property in the same way the repo url is set.

@emgarten emgarten added Priority:1 High priority issues that must be resolved in the current sprint. Functionality:Pack labels Feb 8, 2018
@emgarten emgarten added this to the Backlog milestone Feb 8, 2018
@emgarten emgarten changed the title Add repository/commit attribute to nuspecs Add repository/commit attribute to nuspec format Feb 8, 2018
@joelverhagen
Copy link
Member

Related: NuGet/NuGetGallery#4941.

If this starts showing up in .nuspec, we could also show this on the gallery.

@emgarten
Copy link
Member Author

emgarten commented Feb 9, 2018

Would branch be useful information also? A user could find the branch from the commit hash, but for the gallery's purposes it might be easier to just have this info in the nuspec instead of having to track it down in git.

@joelverhagen
Copy link
Member

Branch can change over time so capturing at pack time would be great, in my opinion.

@StingyJack
Copy link
Contributor

I've tinkered with using projecturl to point to the TFS build that originated the package. Perhaps a set of origination uri's for changeset/commit, branch ident, etc.

Please no git or nuget.org specific implementations.

@emgarten
Copy link
Member Author

These strings are free form, type currently allows any source control system name, so TFS should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Pack Priority:1 High priority issues that must be resolved in the current sprint.
Projects
None yet
Development

No branches or pull requests

3 participants