Add support to allow users to input password through commandline to sign command #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#5904
Regression: No
Fix
Details: This PR adds support in sign command to allow users to interactively type pfx file password securely. To allow this I have added
IPasswordProvider.csand its implementationConsolePasswordProvider.csthat allowsSignCommandRunnerto read password from console in-NonInteractivemode. The underlying implementation comes fromIConsole.ReadSecureString.I have also added some tests using pfx files and done some cleanup in the test code.
Testing/Validation
Tests Added: Yes
Validation done: manual testing with pfx files.