fix bug in dotnet list package & add test #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heng-liu
requested review from
dominoFire,
PatoBeltran,
nkolev92,
zivkan and
jainaashish
nkolev92
approved these changes
Jan 19, 2019
| @@ -375,6 +375,11 @@ internal static bool IsPackageReferenceProject(Project project) | |||
| requestedTargets = filteredTargets; | |||
| } | |||
|
|
|||
| // In 2.2.100 of CLI. DotNet list package would show a section for each TFM and for each TFM/RID. | |||
There was a problem hiding this comment.
Remove this line. You don't need it.
There was a problem hiding this comment.
Thanks! I'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: #7607
Regression: No
Fix
Details: add filter to ignore the TFM + RID records when get resolved versions
Testing/Validation
Tests Added: Yes
Validation: Assets file created correctly with TFM & TFM+RID, only one section per TFM is shown when running dotnet list package command.