Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle negative value for SolutionView width #6146

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

martinrrm
Copy link
Contributor

@martinrrm martinrrm commented Nov 15, 2024

Bug

Fixes: NuGet/Home#13928

Description

If the user has a scaling/font size that affects the PM UI size and make it really small, this affects when we calculate the width of SolutionView, which with the new column it can make it a negative value

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • [] Added tests UI change, tests width different scaling and font size
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@martinrrm martinrrm requested a review from a team as a code owner November 15, 2024 00:09
Copy link
Contributor

@donnie-msft donnie-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate you looking at this so quickly and talking with me about it, as we found the root cause quickly as one involving accessibility.

As I point out in the review comment, there may be more to change. I'm also wondering if we can reduce or eliminate some of this calculation.

My advice for a plan here is:

  1. Talk to Vendors to see if DPI scaling is part of any testing. If so, we can ask them to help us validate that they can repro before this change, and do not repro after this change. /cc @nkolev92 for ideas there.

  2. I'll follow-up by searching for similar accessibility bugs around ListView width and DPI scaling. We could engage the Accessibility team if we need more insight, but I'm not sure we do at this time.

  3. Attempt to reduce the logic further, add tests, anything to simplify and guard against this going forward.

  4. Get this change (or any addendums in step 3) inserted into VS.

@donnie-msft
Copy link
Contributor

Merging per @aortiz-msft

@donnie-msft donnie-msft enabled auto-merge (squash) November 18, 2024 22:45
@donnie-msft donnie-msft merged commit 4736534 into dev Nov 18, 2024
23 checks passed
@donnie-msft donnie-msft deleted the dev-martinrrm-solutionviewsize_error branch November 18, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small Solution PM UI size can cause a System.ArgumentException SolutionView.ListView_SizeChanged
2 participants