From 07c8d2334ebb1233c7efbe1224c01fcfd287c593 Mon Sep 17 00:00:00 2001
From: Joel Verhagen <jver@microsoft.com>
Date: Sat, 6 Apr 2019 15:43:41 -0700
Subject: [PATCH] Add DatabaseOwnerFetcher to query for current owner
 information (#501)

Progress on https://github.com/NuGet/NuGetGallery/issues/6475
---
 .../DependencyInjectionExtensions.cs          |  1 +
 .../NuGet.Services.AzureSearch.csproj         |  2 +
 .../DatabaseOwnerFetcher.cs                   | 59 +++++++++++++++++++
 .../IDatabaseOwnerFetcher.cs                  | 20 +++++++
 .../Owners2AzureSearch/IOwnerSetComparer.cs   | 10 ++++
 .../OwnerDataClientFacts.cs                   |  4 +-
 6 files changed, 94 insertions(+), 2 deletions(-)
 create mode 100644 src/NuGet.Services.AzureSearch/Owners2AzureSearch/DatabaseOwnerFetcher.cs
 create mode 100644 src/NuGet.Services.AzureSearch/Owners2AzureSearch/IDatabaseOwnerFetcher.cs

diff --git a/src/NuGet.Services.AzureSearch/DependencyInjectionExtensions.cs b/src/NuGet.Services.AzureSearch/DependencyInjectionExtensions.cs
index a42be7c99..c2179dc83 100644
--- a/src/NuGet.Services.AzureSearch/DependencyInjectionExtensions.cs
+++ b/src/NuGet.Services.AzureSearch/DependencyInjectionExtensions.cs
@@ -217,6 +217,7 @@ public static IServiceCollection AddAzureSearch(this IServiceCollection services
             services.AddTransient<ICatalogLeafFetcher, CatalogLeafFetcher>();
             services.AddTransient<ICollector, AzureSearchCollector>();
             services.AddTransient<ICommitCollectorLogic, AzureSearchCollectorLogic>();
+            services.AddTransient<IDatabaseOwnerFetcher, DatabaseOwnerFetcher>();
             services.AddTransient<IDiagnosticsService, LoggerDiagnosticsService>();
             services.AddTransient<IEntitiesContextFactory, EntitiesContextFactory>();
             services.AddTransient<IHijackDocumentBuilder, HijackDocumentBuilder>();
diff --git a/src/NuGet.Services.AzureSearch/NuGet.Services.AzureSearch.csproj b/src/NuGet.Services.AzureSearch/NuGet.Services.AzureSearch.csproj
index ef2f4c77f..d64ad9490 100644
--- a/src/NuGet.Services.AzureSearch/NuGet.Services.AzureSearch.csproj
+++ b/src/NuGet.Services.AzureSearch/NuGet.Services.AzureSearch.csproj
@@ -47,6 +47,8 @@
     <Compile Include="Analysis\IdentifierCustomTokenFilter.cs" />
     <Compile Include="Analysis\PackageIdCustomAnalyzer.cs" />
     <Compile Include="Analysis\PackageIdCustomTokenizer.cs" />
+    <Compile Include="Owners2AzureSearch\DatabaseOwnerFetcher.cs" />
+    <Compile Include="Owners2AzureSearch\IDatabaseOwnerFetcher.cs" />
     <Compile Include="Owners2AzureSearch\IOwnerSetComparer.cs" />
     <Compile Include="Owners2AzureSearch\OwnerSetComparer.cs" />
     <Compile Include="Owners2AzureSearch\PackageIdToOwnersBuilder.cs" />
diff --git a/src/NuGet.Services.AzureSearch/Owners2AzureSearch/DatabaseOwnerFetcher.cs b/src/NuGet.Services.AzureSearch/Owners2AzureSearch/DatabaseOwnerFetcher.cs
new file mode 100644
index 000000000..8295ae539
--- /dev/null
+++ b/src/NuGet.Services.AzureSearch/Owners2AzureSearch/DatabaseOwnerFetcher.cs
@@ -0,0 +1,59 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System;
+using System.Collections.Generic;
+using System.Threading.Tasks;
+using Microsoft.Extensions.Logging;
+using NuGet.Jobs;
+using NuGet.Jobs.Configuration;
+
+namespace NuGet.Services.AzureSearch.Owners2AzureSearch
+{
+    public class DatabaseOwnerFetcher : IDatabaseOwnerFetcher
+    {
+        private readonly ISqlConnectionFactory<GalleryDbConfiguration> _connectionFactory;
+        private readonly ILogger<DatabaseOwnerFetcher> _logger;
+
+        private const string Sql = @"
+SELECT
+    pr.Id,
+    u.Username
+FROM PackageRegistrations pr (NOLOCK)
+INNER JOIN PackageRegistrationOwners pro (NOLOCK) ON pro.PackageRegistrationKey = pr.[Key]
+INNER JOIN Users u (NOLOCK) ON pro.UserKey = u.[Key]
+";
+
+        public DatabaseOwnerFetcher(
+            ISqlConnectionFactory<GalleryDbConfiguration> connectionFactory,
+            ILogger<DatabaseOwnerFetcher> logger)
+        {
+            _connectionFactory = connectionFactory ?? throw new ArgumentNullException(nameof(connectionFactory));
+            _logger = logger;
+        }
+
+        public async Task<SortedDictionary<string, SortedSet<string>>> GetPackageIdToOwnersAsync()
+        {
+            using (var connection = await _connectionFactory.OpenAsync())
+            using (var command = connection.CreateCommand())
+            {
+                command.CommandText = Sql;
+
+                using (var reader = await command.ExecuteReaderAsync())
+                {
+                    var builder = new PackageIdToOwnersBuilder(_logger);
+                    while (await reader.ReadAsync())
+                    {
+                        var id = reader.GetString(0);
+                        var username = reader.GetString(1);
+
+                        builder.Add(id, username);
+                    }
+
+                    return builder.GetResult();
+                }
+            }
+        }
+    }
+}
+
diff --git a/src/NuGet.Services.AzureSearch/Owners2AzureSearch/IDatabaseOwnerFetcher.cs b/src/NuGet.Services.AzureSearch/Owners2AzureSearch/IDatabaseOwnerFetcher.cs
new file mode 100644
index 000000000..ff4e45c92
--- /dev/null
+++ b/src/NuGet.Services.AzureSearch/Owners2AzureSearch/IDatabaseOwnerFetcher.cs
@@ -0,0 +1,20 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System.Collections.Generic;
+using System.Threading.Tasks;
+
+namespace NuGet.Services.AzureSearch.Owners2AzureSearch
+{
+    /// <summary>
+    /// Fetches the current owner information from the database.
+    /// </summary>
+    public interface IDatabaseOwnerFetcher
+    {
+        /// <summary>
+        /// Fetch a mapping from package ID to set of owners for each package registration (i.e. package ID) in the
+        /// gallery database.
+        /// </summary>
+        Task<SortedDictionary<string, SortedSet<string>>> GetPackageIdToOwnersAsync();
+    }
+}
\ No newline at end of file
diff --git a/src/NuGet.Services.AzureSearch/Owners2AzureSearch/IOwnerSetComparer.cs b/src/NuGet.Services.AzureSearch/Owners2AzureSearch/IOwnerSetComparer.cs
index a0cb3af24..4b1162e0a 100644
--- a/src/NuGet.Services.AzureSearch/Owners2AzureSearch/IOwnerSetComparer.cs
+++ b/src/NuGet.Services.AzureSearch/Owners2AzureSearch/IOwnerSetComparer.cs
@@ -5,8 +5,18 @@
 
 namespace NuGet.Services.AzureSearch.Owners2AzureSearch
 {
+    /// <summary>
+    /// Used to compare two sets of owners to determine the changes.
+    /// </summary>
     public interface IOwnerSetComparer
     {
+        /// <summary>
+        /// Compares two sets of owners to determine the package IDs that have changed. The returned dictionary
+        /// contains owners that were added, removed, and changed. For the "added" and "changed" cases, the owner set
+        /// is the new data. For the "removed" case, the set is empty.
+        /// </summary>
+        /// <param name="oldData">The old owner information, typically from storage.</param>
+        /// <param name="newData">The new owner information, typically from gallery DB.</param>
         SortedDictionary<string, string[]> Compare(
             SortedDictionary<string, SortedSet<string>> oldData,
             SortedDictionary<string, SortedSet<string>> newData);
diff --git a/tests/NuGet.Services.AzureSearch.Tests/Owners2AzureSearch/OwnerDataClientFacts.cs b/tests/NuGet.Services.AzureSearch.Tests/Owners2AzureSearch/OwnerDataClientFacts.cs
index 38baec372..f284ba39f 100644
--- a/tests/NuGet.Services.AzureSearch.Tests/Owners2AzureSearch/OwnerDataClientFacts.cs
+++ b/tests/NuGet.Services.AzureSearch.Tests/Owners2AzureSearch/OwnerDataClientFacts.cs
@@ -379,7 +379,7 @@ public Facts(ITestOutputHelper output)
                 CloudBlobContainer = new Mock<ICloudBlobContainer>();
                 CloudBlob = new Mock<ISimpleCloudBlob>();
                 Options = new Mock<IOptionsSnapshot<AzureSearchJobConfiguration>>();
-                Logger = output.GetLogger<VersionListDataClient>();
+                Logger = output.GetLogger<OwnerDataClient>();
                 Config = new AzureSearchJobConfiguration
                 {
                     StorageContainer = "unit-test-container",
@@ -422,7 +422,7 @@ public Facts(ITestOutputHelper output)
             public Mock<ICloudBlobContainer> CloudBlobContainer { get; }
             public Mock<ISimpleCloudBlob> CloudBlob { get; }
             public Mock<IOptionsSnapshot<AzureSearchJobConfiguration>> Options { get; }
-            public RecordingLogger<VersionListDataClient> Logger { get; }
+            public RecordingLogger<OwnerDataClient> Logger { get; }
             public AzureSearchJobConfiguration Config { get; }
             public string ETag { get; }
             public Mock<IAccessCondition> AccessCondition { get; }