Fix push package API to return conlfict for existing ID #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Arrange | ||
| var user = new User { EmailAddress = "confirmed@email.com" }; | ||
| var packageRegistration = new PackageRegistration(); | ||
| packageRegistration.Id = "theId"; |
There was a problem hiding this comment.
You might want to do
var sharedPackageId = "theId";
...
packageRegistration.Id = sharedPackageId;
...
var nuGetPackage = TestPackage.CreateTestPackageStream(sharedPackageId, "1.0.42");
...
String.Format(Strings.PackageIdNotAvailable, sharedPackageId));
so that all of the uses are programmatically linked to the same value.
There was a problem hiding this comment.
don't think its much significant #wontfix
|
|
|
@xavierdecoster @ryuyu could I get another sign off? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NuGet/Home#3391 and #3218
/cc @xavierdecoster @ryuyu @scottbommarito @emgarten