Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "Example glob patterns" button and "close" button are not accessible using keyboard #3968

Merged
merged 5 commits into from
May 16, 2017

Conversation

skofman1
Copy link
Contributor

No description provided.

});

$('.globHelpLink')
.click(function () {
$(this).next().find('.popupbox').show();
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False prevents propagation? Maybe comment is useful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@cristinamanum cristinamanum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

@skofman1 skofman1 merged commit 6a7b75c into dev May 16, 2017
@agr agr mentioned this pull request May 16, 2017
22 tasks
@skofman1 skofman1 deleted the acc395308 branch January 4, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants