Avoid separate context from policy service #3982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenriksson
requested review from
joelverhagen,
skofman1,
agr,
loic-sharma,
ryuyu,
cristinamanum and
scottbommarito
joelverhagen
approved these changes
May 17, 2017
skofman1
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue found in DEV: SecurityPolicyService.SubscribeAsync adds user policies but EF wasn't saving the changes to the DB. The issue is that the controller and service have different EF contexts, resulting in a user from the controller being in a detached state when it reaches the policy service.
Changing back to InstancePerLifetimeScope results in the same EF context instance.