From 2dcfdab6a1ef683270e6b8c392a40a0a4d638490 Mon Sep 17 00:00:00 2001
From: Advay Tandon <advaytandon@microsoft.com>
Date: Tue, 8 Nov 2022 15:54:32 -0800
Subject: [PATCH 1/3] initial commit

---
 src/Bootstrap/dist/css/bootstrap.css              | 4 ++++
 src/Bootstrap/less/list-group.less                | 5 +++++
 src/NuGetGallery/Views/Shared/ListPackages.cshtml | 4 ++--
 src/NuGetGallery/Views/Shared/_ListPackage.cshtml | 4 ++--
 src/NuGetGallery/Views/Users/Profiles.cshtml      | 4 ++--
 5 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/src/Bootstrap/dist/css/bootstrap.css b/src/Bootstrap/dist/css/bootstrap.css
index 2253cea0c9..628ba042b0 100644
--- a/src/Bootstrap/dist/css/bootstrap.css
+++ b/src/Bootstrap/dist/css/bootstrap.css
@@ -4723,6 +4723,10 @@ button.list-group-item-danger.active:focus {
   margin-bottom: 0;
   line-height: 1.3;
 }
+ul.list-packages {
+  list-style-type: none;
+  padding-left: 0;
+}
 .panel {
   margin-bottom: 22px;
   background-color: #fff;
diff --git a/src/Bootstrap/less/list-group.less b/src/Bootstrap/less/list-group.less
index f913629cce..d29c86f270 100644
--- a/src/Bootstrap/less/list-group.less
+++ b/src/Bootstrap/less/list-group.less
@@ -128,3 +128,8 @@ button.list-group-item {
   margin-bottom: 0;
   line-height: 1.3;
 }
+
+ul.list-packages {
+  list-style-type: none;
+  padding-left: 0;
+}
\ No newline at end of file
diff --git a/src/NuGetGallery/Views/Shared/ListPackages.cshtml b/src/NuGetGallery/Views/Shared/ListPackages.cshtml
index 8c21553c31..76934e6168 100644
--- a/src/NuGetGallery/Views/Shared/ListPackages.cshtml
+++ b/src/NuGetGallery/Views/Shared/ListPackages.cshtml
@@ -151,7 +151,7 @@
         </div>
     }
 
-    <div class="list-packages" role="list">
+    <ul class="list-packages">
         @{
             var itemIndex = Model.PageIndex * Model.PageSize;
             var eventName = Model.IsPreviewSearch ? "preview-search-selection" : "search-selection";
@@ -161,7 +161,7 @@
             @Html.Partial("_ListPackage", package, new ViewDataDictionary { { "itemIndex", itemIndex }, { "eventName", eventName } })
             itemIndex++;
         }
-    </div>
+    </ul>
 
     <div class="row">
         <div class="col-xs-12 clearfix">
diff --git a/src/NuGetGallery/Views/Shared/_ListPackage.cshtml b/src/NuGetGallery/Views/Shared/_ListPackage.cshtml
index 4de386b1c5..161a683049 100644
--- a/src/NuGetGallery/Views/Shared/_ListPackage.cshtml
+++ b/src/NuGetGallery/Views/Shared/_ListPackage.cshtml
@@ -26,7 +26,7 @@
     }
 }
 
-<article class="package" role="listitem">
+<li class="package">
 
     <div class="row">
         <div class="col-sm-1 hidden-xs hidden-sm col-package-icon">
@@ -131,4 +131,4 @@
             </div>
         </div>
     </div>
-</article>
+</li>
diff --git a/src/NuGetGallery/Views/Users/Profiles.cshtml b/src/NuGetGallery/Views/Users/Profiles.cshtml
index 52d1cb77b3..46be672ad2 100644
--- a/src/NuGetGallery/Views/Users/Profiles.cshtml
+++ b/src/NuGetGallery/Views/Users/Profiles.cshtml
@@ -97,12 +97,12 @@
 
             <hr class="profile-title-divider" />
 
-            <div class="list-packages" role="list">
+            <ul class="list-packages">
                 @foreach (var package in Model.PagedPackages)
                 {
                     @Html.Partial("_ListPackage", package)
                 }
-            </div>
+            </ul>
 
             @ViewHelpers.PreviousNextPager(Model.Pager)
         </article>

From eb51cf0655810a0f8d13c514429008090bb03990 Mon Sep 17 00:00:00 2001
From: Advay Tandon <advaytandon@microsoft.com>
Date: Wed, 9 Nov 2022 13:18:06 -0800
Subject: [PATCH 2/3] removed 'alert' role from Search heading

---
 src/NuGetGallery/Views/Shared/ListPackages.cshtml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/NuGetGallery/Views/Shared/ListPackages.cshtml b/src/NuGetGallery/Views/Shared/ListPackages.cshtml
index 76934e6168..94df3198ed 100644
--- a/src/NuGetGallery/Views/Shared/ListPackages.cshtml
+++ b/src/NuGetGallery/Views/Shared/ListPackages.cshtml
@@ -41,7 +41,7 @@
 <section role="main" class="container main-container page-list-packages">
     <div class="row clearfix no-margin">
         <div class="col-md-10 no-padding">
-            <h1 role="alert">
+            <h1 role="heading">
                 @if (String.IsNullOrEmpty(Model.SearchTerm))
                 {
                     if (Model.TotalCount == 1)

From 9e4b8bb7392c41d33fd6f78e44ebd6ac8c00144e Mon Sep 17 00:00:00 2001
From: Advay Tandon <advaytandon@microsoft.com>
Date: Wed, 9 Nov 2022 15:25:22 -0800
Subject: [PATCH 3/3] removed header role too, unneccessary for h1 elements

---
 src/NuGetGallery/Views/Shared/ListPackages.cshtml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/NuGetGallery/Views/Shared/ListPackages.cshtml b/src/NuGetGallery/Views/Shared/ListPackages.cshtml
index 94df3198ed..5814a27c44 100644
--- a/src/NuGetGallery/Views/Shared/ListPackages.cshtml
+++ b/src/NuGetGallery/Views/Shared/ListPackages.cshtml
@@ -41,7 +41,7 @@
 <section role="main" class="container main-container page-list-packages">
     <div class="row clearfix no-margin">
         <div class="col-md-10 no-padding">
-            <h1 role="heading">
+            <h1 tabindex="0">
                 @if (String.IsNullOrEmpty(Model.SearchTerm))
                 {
                     if (Model.TotalCount == 1)