Fix false negatives from isSupported #90
Open
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
neenhouse
reviewed
Jan 27, 2020
| return browser.split(" ") | ||
| }) | ||
| .every((browser) => { | ||
| return data.stats[browser[0]] && |
There was a problem hiding this comment.
Support case insensitive search for "Y":
return data.stats[browser[0]] &&
data.stats[browser[0]][browser[1]] &&
String.prototype.toLowerCase.call(data.stats[browser[0]][browser[1]][0]) === "y"
There was a problem hiding this comment.
Also, you should incorporate the fix from https://github.com/Nyalab/caniuse-api/pull/61/files here, so:
return data &&
data.stats[browser[0]] &&
data.stats[browser[0]][browser[1]] &&
String.prototype.toLowerCase.call(data.stats[browser[0]][browser[1]][0]) === "y"
|
@Nyalab - I think this PR looks good. Could you take a look? We need a patch version for a new project we maintain https://github.com/ExpediaGroup/nimbuild/tree/master/packages/nimbuild-corejs. |
|
It's been almost a year, can we get this merged?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issues #82 and #83.
The problem is that the data set returns as
y #xwherexis the number mapping to the foot note.