Added support for numeric headers #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks pass for me locally, so this looks mergeable now! @Nyholm should we merge this or do you want to try and trigger Travis first? |
|
Do I need to do anything here? |
|
Tests pass now at least. I upped the version for psr7 to ^1.3 in composer.json. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this whole numeric header thing involves both psr7 and psr7-server, I think we need to make this change to keep everything in line.
Nyholm/psr7#149 needs to be merged into psr7 first, and used in this PR for the tests to pass. I created the PR to demonstrate this.