-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] account fiscal position vat check #1480
[16.0][MIG] account fiscal position vat check #1480
Conversation
…is module checks that the customer has a VAT number on invoice validation if it has a fiscal position flagged "Customer must have VAT".
Set all addons to uninstallable Rename all addons to xxx_unported to be travis compliant Revert "Rename all addons to xxx_unported to be travis compliant" This reverts commit 7eb1827. move all unported addons into __unported__ folder instead of adding _unported suffix
vat is added on partner view in base_vat
Rename manifest files
A yellow warning banner is now displayed on the partner form view when the fiscal position requires a VAT number and the VAT number is missing. This banner replaces the warning message triggered by the onchange. Improve README of the module with v14 screenshots.
- Changed msg on languages that has been translated
Currently translated at 100.0% (9 of 9 strings) Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_fiscal_position_vat_check Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_fiscal_position_vat_check/fr/
@alexis-via @nbessi @yvaucher Bonjour à vous trois, pouvez vous vérifier cette migration, s'il vous plait? Merci d'avance,Syera |
83d7d7f
to
c930ca5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM
/ocabot migration account_fiscal_position_vat_check |
@alexis-via @rafaelbn hey! please i need one another approuval to merge this module, thanks in advance |
@rafaelbn could you review the last commit please ? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1480-by-rafaelbn-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Fails pre-commit @syera94 , please could you review? Thanks |
This PR has the |
Merging after #1496 /ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 490dddc. Thanks a lot for contributing to OCA. ❤️ |
No description provided.