Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account fiscal position vat check #1480

Merged

Conversation

syera94
Copy link
Contributor

@syera94 syera94 commented Oct 20, 2022

No description provided.

Alexis de Lattre and others added 21 commits October 20, 2022 11:33
…is module checks that the customer has a VAT number on invoice validation if it has a fiscal position flagged "Customer must have VAT".
Set all addons to uninstallable

Rename all addons to xxx_unported to be travis compliant

Revert "Rename all addons to xxx_unported to be travis compliant"

This reverts commit 7eb1827.

move all unported addons into __unported__ folder instead of adding _unported suffix
A yellow warning banner is now displayed on the partner form view when
the fiscal position requires a VAT number and the VAT number is missing.
This banner replaces the warning message triggered by the onchange.

Improve README of the module with v14 screenshots.
- Changed msg on languages that has been translated
Currently translated at 100.0% (9 of 9 strings)

Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_fiscal_position_vat_check
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_fiscal_position_vat_check/fr/
@syera94
Copy link
Contributor Author

syera94 commented Oct 20, 2022

@alexis-via @nbessi @yvaucher Bonjour à vous trois, pouvez vous vérifier cette migration, s'il vous plait? Merci d'avance,Syera

@syera94 syera94 force-pushed the 16.0-mig-account_fiscal_position_vat_check branch from 83d7d7f to c930ca5 Compare October 20, 2022 13:54
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@rafaelbn
Copy link
Member

/ocabot migration account_fiscal_position_vat_check

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 24, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 24, 2022
33 tasks
@syera94
Copy link
Contributor Author

syera94 commented Nov 15, 2022

@alexis-via @rafaelbn hey! please i need one another approuval to merge this module, thanks in advance

@bealdav
Copy link
Member

bealdav commented Nov 15, 2022

@rafaelbn could you review the last commit please ? Thanks

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test in runboat 👍

imagen

@rafaelbn
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1480-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 16, 2022
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1480-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rafaelbn
Copy link
Member

Fails pre-commit @syera94 , please could you review? Thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

Merging after #1496

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1480-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 68e8e87 into OCA:16.0 Nov 16, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 490dddc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants