[IMP] SUITE account payment return: Improvements to suite #107

carlosdauden · 2016-10-25T11:50:37Z

Add raise "You can not be removed a payment return if state is 'Done'".
New SEPA return code.
Add check to match returns after import.
Spanish translation.

pedrobaeza · 2016-10-25T11:58:33Z

account_payment_return/models/payment_return.py

+    def unlink(self):
+        if self.filtered(lambda x: x.state == 'done'):
+            raise UserError(_(
+                "You can not be removed a payment return if state is 'Done'"))


Remove be

pedrobaeza · 2016-10-25T11:59:08Z

account_payment_return_import/i18n/es.po

 #, python-format
 msgid ""
 "Could not make sense of the given file.\n"
 "Did you install the module to support this type of file?"
-msgstr "No se pudo hacer con sentido de el archivo dado.\n¿Instalaste el modulo para soportar este tipo de archivo?"
+msgstr ""
+"No se pudo hacer con sentido de el archivo dado.\n"


Trato de usted, no de tú

Leo cosas contradictorias al respecto, por eso nunca lo tengo claro...

pedrobaeza · 2016-10-25T11:59:54Z

account_payment_return_import_sepa_pain/data/unpaid_reason_codes.xml

@@ -42,6 +42,10 @@
        <field name="code">MD01</field>
        <field name="name">No valid Mandate</field>
    </record>
+    <record id="unpaid_reason_MD06" model="payment.return.reason">
+        <field name="code">MD06</field>
+        <field name="name">Disputed authorised transaction</field>


This isn't translated?

https://github.com/OCA/account-payment/pull/107/files#diff-e37f5160827a396976dac1201391ad64R61

pedrobaeza · 2016-10-25T12:38:26Z

Include a test for unlinking returns for not dropping coverage

…urns

carlosdauden · 2016-10-25T16:45:14Z

@pedrobaeza changes done

carlosdauden · 2016-10-25T16:48:06Z

cc @sergio-teruel

pedrobaeza · 2016-10-25T17:00:50Z

Please don't squash while the review process. You only need to squash before merging (when the PR is approved), or it's more difficult to track changes from one review to the next. Reviewer can indicate you if you need to squash or not.

pedrobaeza · 2016-10-25T17:01:51Z

You have to test also a case where there's no error and the payment can be removed.

pedrobaeza

Thanks for the changes.

To the merger: squash on merging

rafaelbn

OK! Thanks

sergio-teruel

Ok..

yajo · 2016-10-26T07:42:48Z

account_payment_return/models/payment_return.py

+        if self.filtered(lambda x: x.state == 'done'):
+            raise UserError(_(
+                "You can not remove a payment return if state is 'Done'"))
+        return super(PaymentReturn, self).unlink()


I'd implement this as a global ir.rule instead.

It is an option, but usually this is the way used and possibly better performance.

The problem is the overlapping of access rules that grants you at the end the unlink. This has to be the way.

Well, I know it's late and after all it works fine this way, but just to clarify, I meant a global rule. Quoting from the above link:

Global rules are subtractive, they must all be matched for a record to be accessible

OK, thanks for clarifying. Odoo doesn't do this kind of things by security rules, so there should be a reason for that. Maybe performance as pointed by Carlos, or maybe to not bypass this check removing access rule.

pedrobaeza · 2016-10-26T09:47:40Z

Merging

pedrobaeza requested changes Oct 25, 2016

View reviewed changes

carlosdauden force-pushed the 8.0-IMP-account_payment_return-SUITE branch from f3739fc to da46560 Compare October 25, 2016 12:21

[IMP] SUITE account payment return: Improvements to suite payment ret…

5232871

…urns

carlosdauden force-pushed the 8.0-IMP-account_payment_return-SUITE branch from da46560 to 5232871 Compare October 25, 2016 16:08

[IMP] SUITE account payment return: Use SavepointCase in tests

80eab8f

carlosdauden force-pushed the 8.0-IMP-account_payment_return-SUITE branch from 008d6da to 80eab8f Compare October 25, 2016 17:22

pedrobaeza approved these changes Oct 25, 2016

View reviewed changes

rafaelbn approved these changes Oct 26, 2016

View reviewed changes

sergio-teruel approved these changes Oct 26, 2016

View reviewed changes

yajo suggested changes Oct 26, 2016

View reviewed changes

pedrobaeza merged commit 9be9f2c into OCA:8.0 Oct 26, 2016

pedrobaeza deleted the 8.0-IMP-account_payment_return-SUITE branch October 26, 2016 09:48

carlosdauden added a commit to Tecnativa/account-payment that referenced this pull request Nov 7, 2016

account_payment_return: Improvements to suite (OCA#107)

31c8a78

carlosdauden added a commit to Tecnativa/account-payment that referenced this pull request Dec 10, 2016

account_payment_return: Improvements to suite (OCA#107)

e51294f

carlosdauden added a commit to Tecnativa/account-payment that referenced this pull request Dec 10, 2016

account_payment_return: Improvements to suite (OCA#107)

8682878

carlosdauden added a commit to Tecnativa/account-payment that referenced this pull request Dec 12, 2016

account_payment_return: Improvements to suite (OCA#107)

bca9baf

pedrobaeza pushed a commit to Tecnativa/account-payment that referenced this pull request Mar 31, 2017

account_payment_return: Improvements to suite (OCA#107)

9ce90d4

pedrobaeza pushed a commit to Tecnativa/account-payment that referenced this pull request Mar 31, 2017

account_payment_return: Improvements to suite (OCA#107)

6aad647

pedrobaeza pushed a commit to Tecnativa/account-payment that referenced this pull request Apr 6, 2017

account_payment_return: Improvements to suite (OCA#107)

484dcdc

pedrobaeza pushed a commit to Tecnativa/account-payment that referenced this pull request Apr 6, 2017

account_payment_return: Improvements to suite (OCA#107)

ec17686

pedrobaeza pushed a commit to Tecnativa/account-payment that referenced this pull request Apr 6, 2017

account_payment_return: Improvements to suite (OCA#107)

f6f81c6

pedrobaeza pushed a commit to Tecnativa/account-payment that referenced this pull request Apr 17, 2017

account_payment_return: Improvements to suite (OCA#107)

c9fe4d8

pedrobaeza pushed a commit to Tecnativa/account-payment that referenced this pull request Apr 17, 2017

account_payment_return: Improvements to suite (OCA#107)

3b05bd6

sergio-teruel pushed a commit to Tecnativa/account-payment that referenced this pull request Jul 2, 2017

account_payment_return: Improvements to suite (OCA#107)

064b079

joao-p-marques pushed a commit to Tecnativa/account-payment that referenced this pull request Mar 17, 2021

account_payment_return: Improvements to suite (OCA#107)

5b3884e

pablo-lp pushed a commit to jimsports/account-payment that referenced this pull request Aug 11, 2021

account_payment_return: Improvements to suite (OCA#107)

b36d1a9

mariadforgeflow pushed a commit to ForgeFlow/account-payment that referenced this pull request Sep 28, 2021

account_payment_return: Improvements to suite (OCA#107)

61c748b

victoralmau pushed a commit to Tecnativa/account-payment that referenced this pull request Nov 10, 2021

account_payment_return: Improvements to suite (OCA#107)

7a9552f

victoralmau pushed a commit to Tecnativa/account-payment that referenced this pull request Nov 11, 2021

account_payment_return: Improvements to suite (OCA#107)

d842f0a

polqubiq pushed a commit to QubiQ/account-payment that referenced this pull request Apr 7, 2022

account_payment_return: Improvements to suite (OCA#107)

c860f3a

LudLaf pushed a commit to Tecnativa/account-payment that referenced this pull request Jun 2, 2022

account_payment_return: Improvements to suite (OCA#107)

a685f62

LudLaf pushed a commit to Tecnativa/account-payment that referenced this pull request Jun 3, 2022

account_payment_return: Improvements to suite (OCA#107)

3a973c7

LudLaf pushed a commit to Tecnativa/account-payment that referenced this pull request Jun 6, 2022

account_payment_return: Improvements to suite (OCA#107)

ccfdcd4

ChrisOForgeFlow pushed a commit to Kencove/account-payment that referenced this pull request Jun 8, 2022

account_payment_return: Improvements to suite (OCA#107)

daf9981

ChrisOForgeFlow pushed a commit to ForgeFlow/account-payment that referenced this pull request Aug 25, 2022

account_payment_return: Improvements to suite (OCA#107)

982d9c7

ChrisOForgeFlow pushed a commit to ForgeFlow/account-payment that referenced this pull request Sep 30, 2022

account_payment_return: Improvements to suite (OCA#107)

4ea7b1b

ChrisOForgeFlow pushed a commit to ForgeFlow/account-payment that referenced this pull request Nov 28, 2022

account_payment_return: Improvements to suite (OCA#107)

5f5ec4a

carlosdauden added a commit to Tecnativa/account-payment that referenced this pull request Feb 27, 2023

account_payment_return: Improvements to suite (OCA#107)

cfc3aff

victoralmau pushed a commit to Tecnativa/account-payment that referenced this pull request Mar 7, 2023

account_payment_return: Improvements to suite (OCA#107)

6a18afb

carlosdauden added a commit to Tecnativa/account-payment that referenced this pull request Mar 7, 2023

account_payment_return: Improvements to suite (OCA#107)

3843543

carlosdauden added a commit to Tecnativa/account-payment that referenced this pull request Mar 7, 2023

account_payment_return: Improvements to suite (OCA#107)

4c563f5

carlosdauden added a commit to Tecnativa/account-payment that referenced this pull request Mar 20, 2023

account_payment_return: Improvements to suite (OCA#107)

c7ecf8f

carlosdauden added a commit to Tecnativa/account-payment that referenced this pull request Mar 21, 2023

account_payment_return: Improvements to suite (OCA#107)

f50b5b8

ao-landoo pushed a commit to landoo-es/account-payment that referenced this pull request Mar 22, 2023

account_payment_return: Improvements to suite (OCA#107)

34ca71b

heliaktiv pushed a commit to heliaktiv/account-payment that referenced this pull request Apr 17, 2023

account_payment_return: Improvements to suite (OCA#107)

38a43d2

Yadier-Tecnativa pushed a commit to Tecnativa/account-payment that referenced this pull request Jun 14, 2023

account_payment_return: Improvements to suite (OCA#107)

2a06e78

Yadier-Tecnativa pushed a commit to Tecnativa/account-payment that referenced this pull request Jul 8, 2023

account_payment_return: Improvements to suite (OCA#107)

db76b72

Ricardoalso pushed a commit to camptocamp/account-payment that referenced this pull request Nov 14, 2023

account_payment_return: Improvements to suite (OCA#107)

c8d1e4d

Ricardoalso pushed a commit to camptocamp/account-payment that referenced this pull request Nov 14, 2023

account_payment_return: Improvements to suite (OCA#107)

7276ec0

Ricardoalso pushed a commit to camptocamp/account-payment that referenced this pull request Nov 14, 2023

account_payment_return: Improvements to suite (OCA#107)

0c0c269

Ricardoalso pushed a commit to camptocamp/account-payment that referenced this pull request Nov 14, 2023

account_payment_return: Improvements to suite (OCA#107)

b7a54eb

carlos-lopez-tecnativa pushed a commit to Tecnativa/account-payment that referenced this pull request Jul 24, 2024

account_payment_return: Improvements to suite (OCA#107)

f2ed355

carolinafernandez-tecnativa pushed a commit to Tecnativa/account-payment that referenced this pull request Jul 25, 2024

account_payment_return: Improvements to suite (OCA#107)

e416bb1

carolinafernandez-tecnativa pushed a commit to Tecnativa/account-payment that referenced this pull request Jul 25, 2024

account_payment_return: Improvements to suite (OCA#107)

fe6c4e9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] SUITE account payment return: Improvements to suite #107

[IMP] SUITE account payment return: Improvements to suite #107

carlosdauden commented Oct 25, 2016 •

edited

Loading

pedrobaeza Oct 25, 2016

pedrobaeza Oct 25, 2016

carlosdauden Oct 25, 2016

pedrobaeza Oct 25, 2016

carlosdauden Oct 25, 2016

pedrobaeza Oct 25, 2016

pedrobaeza commented Oct 25, 2016

carlosdauden commented Oct 25, 2016

carlosdauden commented Oct 25, 2016

pedrobaeza commented Oct 25, 2016

pedrobaeza commented Oct 25, 2016

pedrobaeza left a comment

rafaelbn left a comment

sergio-teruel left a comment

yajo Oct 26, 2016

carlosdauden Oct 26, 2016

pedrobaeza Oct 26, 2016

yajo Oct 26, 2016

pedrobaeza Oct 26, 2016

pedrobaeza commented Oct 26, 2016

[IMP] SUITE account payment return: Improvements to suite #107

[IMP] SUITE account payment return: Improvements to suite #107

Conversation

carlosdauden commented Oct 25, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 25, 2016

carlosdauden commented Oct 25, 2016

carlosdauden commented Oct 25, 2016

pedrobaeza commented Oct 25, 2016

pedrobaeza commented Oct 25, 2016

pedrobaeza left a comment

Choose a reason for hiding this comment

rafaelbn left a comment

Choose a reason for hiding this comment

sergio-teruel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 26, 2016

carlosdauden commented Oct 25, 2016 •

edited

Loading