Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] account_payment_term_partner_holiday #686

Merged

Conversation

antoniospneto
Copy link
Contributor

This is a default migration, and it doesn't require scripts for major versions.

@antoniospneto antoniospneto marked this pull request as draft December 9, 2023 22:25
victoralmau and others added 18 commits February 4, 2024 12:46
…xclude it when payment term assigned in invoices set due dates
…_in_holiday() to filtered correctly when day_to is less than date to compare [IMP] Improve is_date_in_holiday() to work fine in child partners [IMP] Add constraint to holidays to prevent month_to < month_from

[FIX] account_payment_term_partner_holiday: Change month_from and month_to fields to convert in 2 characters to order correctly holidays + Script migration
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-payment-13.0/account-payment-13.0-account_payment_term_partner_holiday
Translate-URL: https://translation.odoo-community.org/projects/account-payment-13-0/account-payment-13-0-account_payment_term_partner_holiday/
…ds account_payment_term_extension and change the way to set correctly due date according payment term lines definition (not +1 day always)
@antoniospneto antoniospneto force-pushed the 14.0-mig-account_payment_term_partner_holiday branch from e9a3e8e to c55841f Compare February 4, 2024 15:52
@antoniospneto antoniospneto force-pushed the 14.0-mig-account_payment_term_partner_holiday branch from c55841f to 3bec556 Compare February 4, 2024 16:20
@antoniospneto
Copy link
Contributor Author

Brought over the improvements from version 15.0 implemented by @LudLaf in PR #523 as they are also valid here.
PR ready for review.

cc @rvalyi @marcelsavegnago @mileo

@antoniospneto antoniospneto marked this pull request as ready for review February 4, 2024 16:29
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@percevaq
Copy link

percevaq commented Apr 4, 2024

LGTM

@antoniospneto
Copy link
Contributor Author

cc @OCA/banking-maintainers

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real changes on the migration

@etobella
Copy link
Member

etobella commented Apr 4, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-686-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3fd7aff into OCA:14.0 Apr 4, 2024
5 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 371c3b4. Thanks a lot for contributing to OCA. ❤️

@percevaq
Copy link

percevaq commented Apr 5, 2024

Collaborating and thanking OCA

@pedrobaeza pedrobaeza added this to the 14.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants