[18.0][MIG] l10n_eu_product_adr: Migration to 18.0 #208
Conversation
chaule97
force-pushed
the
18.0-mig-l10n_eu_product_adr
branch
4 times, most recently
from
7b6dc21 to
0c9c60f
Compare
chaule97
force-pushed
the
18.0-mig-l10n_eu_product_adr
branch
from
0c9c60f to
3dccc14
Compare
| @@ -19,24 +19,18 @@ | |||
| name="adr" | |||
| string="Dangerous Goods" | |||
| groups="l10n_eu_product_adr.group_adr_goods_user" | |||
| attrs="{'invisible': ['|', ('type', '!=', 'product'), '&', ('is_dangerous', '=', False), ('adr_goods_on_variants', '=', False)]}" | |||
| invisible="not (is_storable and (is_dangerous or adr_goods_on_variants))" | |||
There was a problem hiding this comment.
are we sure this is the same ?
I would have written this not is_storable or (is_dangerous and adr_goods_on_variants)
There was a problem hiding this comment.
no, it will be: not is_storable or (not is_dangerous and not adr_goods_on_variants)
There was a problem hiding this comment.
Thanks for the change it looks better IMO
chaule97
force-pushed
the
18.0-mig-l10n_eu_product_adr
branch
2 times, most recently
from
94b6550 to
8a6ce61
Compare
chaule97
force-pushed
the
18.0-mig-l10n_eu_product_adr
branch
from
8a6ce61 to
7d47552
Compare
Hi @TDu ,I have checked the differences between PR 16.0 and branch 14.0. The PR 16.0 had incorrect group permissions. I have updated. thank you |
chaule97
changed the title
Currently translated at 80.3% (98 of 122 strings) Translation: community-data-files-13.0/community-data-files-13.0-l10n_eu_product_adr Translate-URL: https://translation.odoo-community.org/projects/community-data-files-13-0/community-data-files-13-0-l10n_eu_product_adr/nl/
Currently translated at 81.1% (99 of 122 strings) Translation: community-data-files-13.0/community-data-files-13.0-l10n_eu_product_adr Translate-URL: https://translation.odoo-community.org/projects/community-data-files-13-0/community-data-files-13-0-l10n_eu_product_adr/nl/
Co-authored-by: Iryna Vyshnevska <iryna.vyshnevska@camptocamp.com>
chaule97
force-pushed
the
18.0-mig-l10n_eu_product_adr
branch
from
7d47552 to
f5dfe98
Compare
|
|
||
| # def test_06_product_variant_migration(self): | ||
| # """Test the migration of the adr fields from template to product""" | ||
| # try: | ||
| # from openupgradelib import openupgrade # noqa: F401 | ||
| # except ImportError: | ||
| # logging.getLogger("odoo.addons.l10n_eu_product_adr.tests").info( | ||
| # "OpenUpgrade not found, skip test" |
There was a problem hiding this comment.
I wouldn't drop this test, as it probably had meaning in the past.
It is probably meant to be activated again once code is fixed.
There was a problem hiding this comment.
Hi @mmequignon , I think this was the test that went with the migration code for version 14, it's obsolete/not needed now
|
This PR has the |
|
/ocabot migration l10n_eu_product_adr |
|
This PR looks fantastic, let's merge it! |
|
@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-208-by-simahawk-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
chaule97
force-pushed
the
18.0-mig-l10n_eu_product_adr
branch
from
f5dfe98 to
86b91a3
Compare
|
Ciao @simahawk , could you merge again please? |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at d184a36. Thanks a lot for contributing to OCA. ❤️ |
test_06_product_variant_migrationbecause there is no more pre-migration in Odoo 16+._compute_display_namemethod inAdrClassandAdrGoodsbecause thename_searchmethod in Odoo 18 has changed and usedisplay_namevalue to return result.