Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0] Add field 'UNECE Due date' on taxes and corresponding nomenclature #26

Merged
merged 8 commits into from
Oct 13, 2017

Conversation

alexis-via
Copy link
Contributor

This is required for Factur-X support, cf this PR OCA/edi#22

Improve search view on unece code list.

…equired for Factur-X support)

Improve search view on unece code list.
…lues; we decide to use only 1 for invoice generation and we have a hack on import
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change version number

"fiscal administration. For a purchase VAT tax, it is the date "
"on which that VAT can be deducted.")
unece_due_date_code = fields.Char(
related='unece_due_date_id.code', store=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it readonly=True or you will have undesired writes.

'unece.code.list', string='UNECE Due Date',
domain=[('type', '=', 'date')], ondelete='restrict',
help="Select the due date of that tax from the official "
"nomenclature of the United Nations Economic "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align this at the level of the first "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 is happy with it. I think it's a matter of taste here...

@alexis-via
Copy link
Contributor Author

I got the info that probably other changes in nomenclature part of the Factur-X standard will take place. So this PR should be merged when the final version of the standard is published (scheduled for September 30th)

@alexis-via
Copy link
Contributor Author

This is now ready to be merged. I updated all the UNECE nomenclatures and the Factur-X standard has been frozen.

@alexis-via
Copy link
Contributor Author

Conflict resolved. Ready to merge.

@pedrobaeza pedrobaeza merged commit 31c3c37 into OCA:10.0 Oct 13, 2017
antoinecln pushed a commit to antoinecln/community-data-files that referenced this pull request Nov 23, 2018
antoinecln pushed a commit to antoinecln/community-data-files that referenced this pull request Nov 23, 2018
antoinecln pushed a commit to antoinecln/community-data-files that referenced this pull request Nov 23, 2018
levkar pushed a commit to levkar/community-data-files that referenced this pull request Dec 5, 2018
levkar pushed a commit to levkar/community-data-files that referenced this pull request Dec 5, 2018
levkar pushed a commit to levkar/community-data-files that referenced this pull request Dec 5, 2018
levkar pushed a commit to levkar/community-data-files that referenced this pull request Dec 16, 2018
levkar pushed a commit to levkar/community-data-files that referenced this pull request Dec 16, 2018
levkar pushed a commit to levkar/community-data-files that referenced this pull request Dec 16, 2018
joshuajan pushed a commit to shine-it/community-data-files that referenced this pull request Dec 28, 2018
joshuajan pushed a commit to shine-it/community-data-files that referenced this pull request Dec 28, 2018
joshuajan pushed a commit to shine-it/community-data-files that referenced this pull request Jan 5, 2019
joshuajan pushed a commit to shine-it/community-data-files that referenced this pull request Jan 14, 2019
pedrobaeza pushed a commit to levkar/community-data-files that referenced this pull request Feb 22, 2019
pedrobaeza pushed a commit to levkar/community-data-files that referenced this pull request Feb 22, 2019
astirpe pushed a commit to onesteinbv/community-data-files that referenced this pull request Oct 23, 2019
astirpe pushed a commit to onesteinbv/community-data-files that referenced this pull request Oct 23, 2019
astirpe pushed a commit to onesteinbv/community-data-files that referenced this pull request Dec 17, 2019
astirpe pushed a commit to onesteinbv/community-data-files that referenced this pull request Dec 17, 2019
alexis-via pushed a commit to akretion/community-data-files that referenced this pull request Oct 16, 2020
alexis-via pushed a commit to akretion/community-data-files that referenced this pull request Oct 17, 2020
StefanRijnhart pushed a commit to StefanRijnhart/community-data-files that referenced this pull request Jan 18, 2021
alexis-via pushed a commit to akretion/community-data-files that referenced this pull request Dec 6, 2021
syera94 pushed a commit to akretion/community-data-files that referenced this pull request Nov 4, 2022
syera94 pushed a commit to akretion/community-data-files that referenced this pull request Nov 4, 2022
nguyenminhchien pushed a commit to nguyenminhchien/community-data-files that referenced this pull request Feb 2, 2024
nguyenminhchien pushed a commit to nguyenminhchien/community-data-files that referenced this pull request Mar 4, 2024
nguyenminhchien pushed a commit to nguyenminhchien/community-data-files that referenced this pull request Mar 5, 2024
LucasTran380381 pushed a commit to LucasTran380381/community-data-files that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants