From c98c7a43a008aac8436c02804768f33cbe5ad042 Mon Sep 17 00:00:00 2001
From: Lorenzo Battistini <lorenzo.battistini@agilebg.com>
Date: Sun, 10 Mar 2019 12:09:03 +0100
Subject: [PATCH] Do not validate pickings already done. (#1110)

Otherwise
odoo.exceptions.UserError: ('You cannot validate a transfer if no quantites are reserved nor done. To force the transfer, switch in edit more and encode the done quantities.', '')
---
 l10n_it_ddt/tests/test_ddt.py | 29 ++++++++++++-----------------
 1 file changed, 12 insertions(+), 17 deletions(-)

diff --git a/l10n_it_ddt/tests/test_ddt.py b/l10n_it_ddt/tests/test_ddt.py
index 1e1e841bd2b9..57629e4abfd9 100644
--- a/l10n_it_ddt/tests/test_ddt.py
+++ b/l10n_it_ddt/tests/test_ddt.py
@@ -214,11 +214,10 @@ def test_action_put_in_pack_done_pickings_error(self):
         self.picking.action_confirm()
         self.picking.action_assign()
         wiz_vals = self.picking.button_validate()
-        if wiz_vals:
-            # The picking might require further approval
-            wiz = self.env[wiz_vals['res_model']] \
-                .browse(wiz_vals['res_id'])
-            wiz.process()
+        # The picking requires further approval
+        wiz = self.env[wiz_vals['res_model']] \
+            .browse(wiz_vals['res_id'])
+        wiz.process()
         self.ddt.picking_ids = [(6, 0, [self.picking.id, ])]
         self.picking.action_done()
         self.assertTrue(self.ddt.check_if_picking_done)
@@ -311,12 +310,10 @@ def test_sale_order(self):
         order3.picking_ids.action_assign()
         for picking in order3.picking_ids:
             wiz_vals = picking.button_validate()
-            if wiz_vals:
-                # The picking might require further approval
-                wiz = self.env[wiz_vals['res_model']] \
-                    .browse(wiz_vals['res_id'])
-                wiz.process()
-            picking.button_validate()
+            # The picking might require further approval
+            wiz = self.env[wiz_vals['res_model']] \
+                .browse(wiz_vals['res_id'])
+            wiz.process()
 
         # test invoice
         wizard = self.env['sale.advance.payment.inv'].with_context({
@@ -400,12 +397,10 @@ def test_set_done(self):
         picking1.action_assign()
         ddt = self._create_ddt(picking1)
         wiz_vals = picking1.button_validate()
-        if wiz_vals:
-            # The picking might require further approval
-            wiz = self.env[wiz_vals['res_model']] \
-                .browse(wiz_vals['res_id'])
-            wiz.process()
-        picking1.button_validate()
+        # The picking might require further approval
+        wiz = self.env[wiz_vals['res_model']] \
+            .browse(wiz_vals['res_id'])
+        wiz.process()
         ddt.set_done()
         self.assertTrue('DDT' in ddt.display_name)
         self.assertEqual(ddt.weight, 0)