[10.0][IMP][l10n_it_fiscalcode] Add fiscalcode in partner search view

[robyf70]

This PR simply add fiscalcode to partner search view.

[eLBati]

LGTM

[tafaRU]

why didn't you use filter instead of search?

[robyf70]

Do you mean replace search with filter?

[tafaRU]

yes!

[robyf70]

and ... because we have only one entry?

[tafaRU]

You're inheriting so there is no need to use <search>, tag <filter> is enough.

[tafaRU]

I meant something like:

    <record id="view_res_partner_filter_fiscalcode_data" model="ir.ui.view">
        <field name="name">res.partner.fiscalcode.filter</field>
        <field name="model">res.partner</field>
        <field name="inherit_id" ref="base.view_res_partner_filter"/>
        <field name="arch" type="xml">
            <filter name="parent_id" position="after">
                <field name="fiscalcode"/>
            </filter>
        </field>
    </record>

But your solution works just the same so 👍

[eLBati]

How can this work without position?

[robyf70]

Guys, what do you think if we can also add the vat field as searchable? This is one of the most requested field to be searchable in partner and I haven't really found the right place, on l10n_it_* modules, where to add it.

[tafaRU]

I tried locally: it works and all filters seem to be kept.
I also found a similar case: https://github.com/odoo/odoo/blob/10.0/addons/website_sale/views/backend.xml#L29-L31

[SimoRubi]

It works because the default for position is inside: https://github.com/odoo/odoo/blob/a409627602ab6c03364b492b5ba7a6fbaba6c5d6/odoo/addons/base/ir/ir_ui_view.py#L554

[eLBati]

How can this work without position?

[robyf70]

It works because default position="inside" like @SimoRubi said, but if you want to make it explicit we will go for the standard way that @tafaRU brought up. Just let me know what you prefer.

[eLBati]

Thanks, didn't know