Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD][l10n_it_fatturapa_out] add method to convert euro to currency #2684

Closed
wants to merge 5 commits into from
Closed

[ADD][l10n_it_fatturapa_out] add method to convert euro to currency #2684

wants to merge 5 commits into from

Conversation

matteoopenf
Copy link
Contributor

No description provided.

@matteoopenf matteoopenf marked this pull request as ready for review February 23, 2022 10:23
This was referenced Feb 23, 2022
Merged
Closed
@eLBati
Copy link
Member

eLBati commented Mar 20, 2022

Quindi questa sarebbe una evoluzione della #2563 ?
@matteoopenf @TheMule71

@matteoopenf
Copy link
Contributor Author

Quindi questa sarebbe una evoluzione della #2563 ?

@matteoopenf @TheMule71

Esatto

@eLBati
Copy link
Member

eLBati commented Apr 4, 2022

@matteoopenf puoi verificare travis?

@eLBati eLBati mentioned this pull request Apr 4, 2022
Merged
@matteoopenf
Copy link
Contributor Author

@eLBati non mi è chiaro l'errore di travis

@matteoopenf
Copy link
Contributor Author

cioè ho visto questo:
Your code has been rated at 9.90/10
count_errors 0
Starting lint check only for modules changed
From https://github.com/OCA/l10n-italy

  • [new branch] 12.0 -> origin/12.0
    ************* Module l10n_it_fatturapa_out.models.partner
    l10n_it_fatturapa_out/models/partner.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
    ************* Module l10n_it_fatturapa_out.models.company
    l10n_it_fatturapa_out/models/company.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
    ************* Module l10n_it_fatturapa_out.wizard.wizard_export_fatturapa_regenerate
    l10n_it_fatturapa_out/wizard/wizard_export_fatturapa_regenerate.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
    l10n_it_fatturapa_out/wizard/wizard_export_fatturapa_regenerate.py:11: [W7950(odoo-addons-relative-import), ] Same Odoo module absolute import. You should use relative import with "." instead of "openerp.addons.l10n_it_fatturapa_out"

Ma non mi è molto chiaro

@eLBati
Copy link
Member

eLBati commented Apr 7, 2022

Travis fallisce per
l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py:818:17: F841 local variable 'ImportoPagamento' is assigned to but never used
e

2022-02-23 10:54:11,301 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: FAIL

2022-02-23 10:54:11,301 9855 INFO openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: ======================================================================

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: FAIL: test_e_invoice_ddt (odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt.TestInvoiceDDT)

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: Traceback (most recent call last):

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: `   File "/home/travis/build/OCA/l10n-italy/setup/l10n_it_fatturapa_out_ddt/odoo/addons/l10n_it_fatturapa_out_ddt/tests/test_fatturapa_ddt.py", line 96, in test_e_invoice_ddt

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: `     module_name='l10n_it_fatturapa_out_ddt'

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: `   File "/home/travis/build/OCA/l10n-italy/setup/l10n_it_fatturapa_out/odoo/addons/l10n_it_fatturapa_out/tests/fatturapa_common.py", line 126, in check_content

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: `     self.assertEqual(etree.tostring(test_fatt), etree.tostring(xml))

2022-02-23 10:54:11,303 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: ` AssertionError: b'<ns[1581 chars]visa>USD</Divisa><Data>2018-01-07</Data><Numer[1140 chars]ica>' != b'<ns[1581 chars]visa>EUR</Divisa><Data>2018-01-07</Data><Numer[1533 chars]ica>'

2022-02-23 10:54:11,303 9855 INFO openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: Ran 1 test in 4.482s

2022-02-23 10:54:11,303 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: FAILED

@matteoopenf
Copy link
Contributor Author

Travis fallisce per l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py:818:17: F841 local variable 'ImportoPagamento' is assigned to but never used e

2022-02-23 10:54:11,301 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: FAIL

2022-02-23 10:54:11,301 9855 INFO openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: ======================================================================

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: FAIL: test_e_invoice_ddt (odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt.TestInvoiceDDT)

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: Traceback (most recent call last):

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: `   File "/home/travis/build/OCA/l10n-italy/setup/l10n_it_fatturapa_out_ddt/odoo/addons/l10n_it_fatturapa_out_ddt/tests/test_fatturapa_ddt.py", line 96, in test_e_invoice_ddt

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: `     module_name='l10n_it_fatturapa_out_ddt'

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: `   File "/home/travis/build/OCA/l10n-italy/setup/l10n_it_fatturapa_out/odoo/addons/l10n_it_fatturapa_out/tests/fatturapa_common.py", line 126, in check_content

2022-02-23 10:54:11,302 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: `     self.assertEqual(etree.tostring(test_fatt), etree.tostring(xml))

2022-02-23 10:54:11,303 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: ` AssertionError: b'<ns[1581 chars]visa>USD</Divisa><Data>2018-01-07</Data><Numer[1140 chars]ica>' != b'<ns[1581 chars]visa>EUR</Divisa><Data>2018-01-07</Data><Numer[1533 chars]ica>'

2022-02-23 10:54:11,303 9855 INFO openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: Ran 1 test in 4.482s

2022-02-23 10:54:11,303 9855 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_ddt.tests.test_fatturapa_ddt: FAILED

Grazie, dovrei aver capito e ho provato a fixare, in caso poi unisco i tre commit

@matteoopenf
Copy link
Contributor Author

@eLBati ora manca da fixare il test sul codice ci siamo, giusto?

@matteoopenf
Copy link
Contributor Author

@TheMule71 per caso sai come correggere il test e così sistemo definitivamente intanto unisco gli ultimi commit avendo risolto il problema precedente

@matteoopenf
[IMP][l10n_it_fatturapa_out] the data invoice relative line and total…
0c30bea 
… amount it is converted with the currency of invoice

[FIX][l10n_it_fatturapa_out] fix field ImportoPagamento not assign

[FIX][l10n_it_fatturapa_out] fix missing field
@matteoopenf matteoopenf force-pushed the 12.0-e_fattura_euro_valuta branch from 9d3275f to 0c30bea Compare April 8, 2022 11:17
@matteoopenf
Copy link
Contributor Author

ho aggiunto una dipendenza altrimenti si rompeva, in caso di fatture in rc

@matteoopenf
Copy link
Contributor Author

@TheMule71 hai idea per sistemare i test qui così mergiamo anche questa?

@matteoopenf
Copy link
Contributor Author

matteoopenf commented May 17, 2022 •
edited
Loading

2d3111f @TheMule71 qui ho ripreso il tuo commit se funziona creo un committ o qualcosa di simile ossia ho preso https://github.com/OCA/l10n-italy/pull/2042/files#diff-914565354eea6151b103fe044fbc59e9406e4df75dd4143da361a2873a4c246eR94-R107

@matteoopenf matteoopenf force-pushed the 12.0-e_fattura_euro_valuta branch from 2d3111f to b59ffde Compare July 14, 2022 10:02
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 21, 2024
@github-actions github-actions bot closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12.0 missing issue stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteoopenf @eLBati @francesco-ooops