IMP l10n_it_fatturapa_out check on invoice lines #558

eLBati · 2018-07-23T09:03:05Z

ADD preventive_checks to be used for generic data tests

tafaRU · 2018-07-23T09:04:53Z

l10n_it_fatturapa_out/models/account.py

+        for line in self.invoice_line_ids:
+            if '\n' in line.name:
+                raise UserError(_(
+                    "Invoice line [%s] must not contain new line charcter"


s/charcter/character

@tafaRU thanks , done

SimoRubi · 2018-07-23T09:56:54Z

@eLBati what is the issue you are experiencing with the newline character?

eLBati · 2018-07-23T10:07:22Z

@SimoRubi

Type {http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2}String1000LatinType cannot be created from {http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2}String1000LatinType: Mouse
Optical

SimoRubi

It might be useful to include the error you are getting in the commit, for future understanding of the change.
Anyway it's good already for me

eLBati · 2018-07-23T13:00:22Z

@SimoRubi commit message improved

tafaRU · 2018-07-23T16:16:59Z

@eLBati, please update the module version accordingly, then I'll merge it. Thanks!

…d get 'Type {http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2}String1000LatinType cannot be created from {http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2}String1000LatinType: Mouse Optical' ADD preventive_checks to be used for generic data tests

eLBati · 2018-07-24T06:19:30Z

@tafaRU done

…d get (OCA#558) 'Type {http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2}String1000LatinType cannot be created from {http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2}String1000LatinType: Mouse Optical' ADD preventive_checks to be used for generic data tests

IMP l10n_it_fatturapa_out check on invoice lines. Otherwise user would get (OCA#558) 'Type {http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2}String1000LatinType cannot be created from {http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2}String1000LatinType: Mouse Optical' ADD preventive_checks to be used for generic data tests IMP l10n_it_fatturapa_out: showing the XML field that is failing (for ProgressivoInvio) (OCA#571)

…d get (OCA#558) 'Type {http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2}String1000LatinType cannot be created from {http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2}String1000LatinType: Mouse Optical' ADD preventive_checks to be used for generic data tests

eLBati added the needs review label Jul 23, 2018

eLBati added this to the 10.0 milestone Jul 23, 2018

tafaRU requested changes Jul 23, 2018

View reviewed changes

eLBati force-pushed the 10.0-imp-fatturapa-check branch from f665523 to 9d7d396 Compare July 23, 2018 09:10

tafaRU approved these changes Jul 23, 2018

View reviewed changes

SimoRubi approved these changes Jul 23, 2018

View reviewed changes

eLBati force-pushed the 10.0-imp-fatturapa-check branch from 9d7d396 to 932f712 Compare July 23, 2018 12:59

eLBati force-pushed the 10.0-imp-fatturapa-check branch from 932f712 to c9b89a6 Compare July 24, 2018 06:19

tafaRU merged commit c3dd207 into OCA:10.0 Jul 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IMP l10n_it_fatturapa_out check on invoice lines #558

IMP l10n_it_fatturapa_out check on invoice lines #558

eLBati commented Jul 23, 2018

tafaRU Jul 23, 2018

eLBati Jul 23, 2018

SimoRubi commented Jul 23, 2018

eLBati commented Jul 23, 2018

SimoRubi left a comment

eLBati commented Jul 23, 2018

tafaRU commented Jul 23, 2018

eLBati commented Jul 24, 2018

IMP l10n_it_fatturapa_out check on invoice lines #558

IMP l10n_it_fatturapa_out check on invoice lines #558

Conversation

eLBati commented Jul 23, 2018

tafaRU Jul 23, 2018

Choose a reason for hiding this comment

eLBati Jul 23, 2018

Choose a reason for hiding this comment

SimoRubi commented Jul 23, 2018

eLBati commented Jul 23, 2018

SimoRubi left a comment

Choose a reason for hiding this comment

eLBati commented Jul 23, 2018

tafaRU commented Jul 23, 2018

eLBati commented Jul 24, 2018