[18.0][MIG] mail_tracking_mass_mailing: Migration to 18.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ADD] mail_tracking_mass_mailing ============================== Mail tracking for mass mailing ============================== Links mail statistics objects with mail tracking objects. Installation ============ This addon will be automatically installed when 'mail_tracking' and 'mass_mailing' are both installed Usage ===== From mail statistic object, you can see: - Email tracking state - Email related tracking object - Email related tracking events From mass mailing contact, you can see: - Email score, in order to clean up your lists from bad score emails As a bonus feature, you have a new checkbox 'Avoid resend' in mass mailing, in order to not send twice the same email to the same recipient. This is very useful when you want to resend the mass mailing after changing selection recipients. Notice that recipient selection could be a domain over a model, so result ids could change over the time. With this flag you can send the same email several times but only once to each recipient. OCA Transbot updated translations from Transifex
OCA Transbot updated translations from Transifex
Testing this addon failed if i.e. `mass_mailing_list_dynamic` was installed before. Moving tests to post-install mode fixes integration tests.
* Standard procedure * Adapt tests * New README by fragments [UPD] README.rst
Update translation files
[UPD] Update mail_tracking_mass_mailing.pot
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.
Translation: social-12.0/social-12.0-mail_tracking_mass_mailing
Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_tracking_mass_mailing/
[UPD] README.rst
Translated using Weblate (Portuguese)
Currently translated at 94.7% (18 of 19 strings)
Translation: social-12.0/social-12.0-mail_tracking_mass_mailing
Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_tracking_mass_mailing/pt/
Translated using Weblate (Slovenian)
Currently translated at 100.0% (19 of 19 strings)
Translation: social-12.0/social-12.0-mail_tracking_mass_mailing
Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_tracking_mass_mailing/sl/
* Change references to mail_mail_statistics model with mail_trace * Change references to mail.mass_mailing model with mailing.mailing * Change reference to statistics_ids field with mailing_trace_ids * Change reference to send_mail method with action_send_mail * Replace mailing.mailing name for required subject field * fix view reference not_blacklisted with filter_not_email_bl * fix not-stored compute, set value for all the records
If an exception is caught by ir.mail_server.send_email in mail_tracking module, the mail.tracking.email record will appear in error but the related mailing trace would still appear as sent because mail.mail._postprocess_sent_message is called without any failure_type in mail.mail._send in the mail module (as Exception is not raised after being caught in mail_tracking module). Since _postprocess_sent_message method not only sets the mailing.trace state in mass_mailing module but can also delete the mail.mail records in mail module, we need to ensure the mailing.trace is written accordingly to the tracking here, and avoid having the mass_mailing module set a 'sent' status if we had an exception, hence the usage of a context key to ignore possible writes.
Currently translated at 100.0% (20 of 20 strings) Translation: social-16.0/social-16.0-mail_tracking_mass_mailing Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking_mass_mailing/es/
Currently translated at 95.0% (19 of 20 strings) Translation: social-16.0/social-16.0-mail_tracking_mass_mailing Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking_mass_mailing/it/
Currently translated at 95.0% (19 of 20 strings) Translation: social-16.0/social-16.0-mail_tracking_mass_mailing Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking_mass_mailing/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_tracking_mass_mailing Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking_mass_mailing/
| { | ||
| "pull_requests": { | ||
| "1244": "skip precommit changes", | ||
| "1048": "(auto) Nothing to port from PR #1048" |
There was a problem hiding this comment.
This will probably not work as expected here, as this is a new repo.
These PR ids are from OCA/social
There was a problem hiding this comment.
Hi, indeed, it should be dropped
There was a problem hiding this comment.
Yes, there is a fix that has been merged lately to store the full PR ref: OCA/oca-port#57
This allows to support blacklisting of PRs cross-repo.
There was a problem hiding this comment.
mmequignon
approved these changes
Nov 7, 2024
trisdoan
force-pushed
the
18.0-mig-mail_tracking_mass_mailing
branch
from
4bd509e to
60f9e72
Compare
ivantodorovich
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note