Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] stock_picking_product_link_margin #205

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

carmenbianca
Copy link
Member

Super simple module. The customer need is to more easily access the margin list view from stock pickings.

Internal task: https://gestion.coopiteasy.be/web#id=11376&action=479&model=project.task&view_type=form&menu_id=536

@carmenbianca carmenbianca marked this pull request as draft May 9, 2024 12:17
@carmenbianca carmenbianca marked this pull request as ready for review May 9, 2024 12:37
@victor-champonnois
Copy link
Member

victor-champonnois commented May 9, 2024

To give a bit more context : this module is for supermarkets (or any store) who use product_margin_classification but want to apply the margin when receiving the delivery, rather than when receiving the invoice.

Copy link
Member

@victor-champonnois victor-champonnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionnal review OK

@carmenbianca
Copy link
Member Author

@victor-champonnois added your target audience description to the documentation

Copy link

github-actions bot commented Sep 8, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 8, 2024
@carmenbianca
Copy link
Member Author

Not stale :) @remytms can you review?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
Copy link
Member Author

Hi @legalsylvain. I've added a note to CONFIGURE.rst:

In order to use this module, you must enable product variants. The necessary margin view does not exist for product templates.

But our client doesn't want to enable product variants, so I'll have to chase this down.

Before I run off to apply patches everywhere, is there a reason why the list view is for product.product instead of product.template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants