Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] github.search_migration_pr: fix matching of module name in PR title #38

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

sebalix
Copy link
Collaborator

@sebalix sebalix commented Sep 7, 2023

The PR title is split by words without including special characters (this doesn't include _).

Before this change, the term to match against could have been my_module:, e.g.:

$ oca-port 14.0 16.0 stock_warehouse_flow --output=json | jq .
{
  "process": "migrate",
  "results": {}
}

With this change, the term to match become my_module:

$ oca-port 14.0 16.0 stock_warehouse_flow --output=json | jq .
{
  "process": "migrate",
  "results": {
    "existing_pr": {
      "url": "https://github.com/OCA/wms/pull/704",
      "ref": "OCA/wms#704",
      "author": "RodrigoBM",
      "title": "[16.0][MIG] stock_warehouse_flow: Migration to 16.0",
      "merged_at": "",
      "number": 704
    }
  }
}

@sebalix sebalix requested a review from simahawk September 7, 2023 07:48
@sebalix sebalix force-pushed the fix-search_migration_pr branch from 7c76eac to c2bf388 Compare September 7, 2023 08:04
@sebalix sebalix added this to the 0.14 milestone Sep 7, 2023
The PR title is split by words without including special characters.

Before this change, the term to match against could have been 'my_module:'.
With this change, the term to match become 'my_module'.
@sebalix sebalix force-pushed the fix-search_migration_pr branch from c2bf388 to bce6ff8 Compare September 7, 2023 08:24
@sebalix sebalix changed the title [FIX] utils.search_migration_pr: fix matching of module name in PR title [FIX] github.search_migration_pr: fix matching of module name in PR title Sep 7, 2023
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests ❤️

@sebalix sebalix merged commit fa7b950 into OCA:main Sep 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants