diff --git a/partner_industry_secondary/__manifest__.py b/partner_industry_secondary/__manifest__.py index 483fd4875125..620c2ae4dabc 100644 --- a/partner_industry_secondary/__manifest__.py +++ b/partner_industry_secondary/__manifest__.py @@ -6,7 +6,7 @@ { "name": "Partner Industry Secondary", "summary": "Add secondary partner industries", - "version": "16.0.1.0.1", + "version": "17.0.1.0.0", "category": "Sales", "website": "https://github.com/OCA/partner-contact", "author": "Tecnativa, Odoo Community Association (OCA)", diff --git a/partner_industry_secondary/models/res_partner_industry.py b/partner_industry_secondary/models/res_partner_industry.py index fe05971af803..1e2957a4cfff 100644 --- a/partner_industry_secondary/models/res_partner_industry.py +++ b/partner_industry_secondary/models/res_partner_industry.py @@ -23,16 +23,13 @@ class ResPartnerIndustry(models.Model): ) parent_path = fields.Char(index=True, unaccent=False) - def name_get(self): - def get_names(cat): - """Return the list [cat.name, cat.parent_id.name, ...]""" - res = [] - while cat: - res.insert(0, cat.name) - cat = cat.parent_id - return res - - return [(cat.id, " / ".join(get_names(cat))) for cat in self] + @api.depends("name", "parent_id") + def _compute_display_name(self): + for rec in self: + if rec.parent_id: + rec.display_name = rec.parent_id.display_name + " / " + rec.name + else: + rec.display_name = rec.name @api.constrains("name", "parent_id") def _check_uniq_name(self): diff --git a/partner_industry_secondary/tests/test_res_partner_industry.py b/partner_industry_secondary/tests/test_res_partner_industry.py index 0068643bdba0..b47f3aab68bc 100644 --- a/partner_industry_secondary/tests/test_res_partner_industry.py +++ b/partner_industry_secondary/tests/test_res_partner_industry.py @@ -16,6 +16,14 @@ def setUpClass(cls): cls.industry_child = cls.industry_model.create( {"name": "Test child", "parent_id": cls.industry_main.id} ) + cls.env.user.groups_id = [ + ( + 4, + cls.env.ref( + "partner_industry_secondary.group_use_partner_industry_for_person" + ).id, + ) + ] cls.partner = cls.env["res.partner"].create({"name": "Test partner"}) def test_00_check_industries(self): @@ -50,3 +58,7 @@ def test_05_check_partner_industries(self): self.partner.write( {"industry_id": main.id, "secondary_industry_ids": [(6, 0, both.ids)]} ) + + def test_06_check_show_partner_industry_for_person(self): + self.partner._compute_show_partner_industry_for_person() + self.assertEqual(self.partner.show_partner_industry_for_person, True) diff --git a/partner_industry_secondary/views/res_config_settings.xml b/partner_industry_secondary/views/res_config_settings.xml index c4a8e901f6de..7ca49a4845c5 100644 --- a/partner_industry_secondary/views/res_config_settings.xml +++ b/partner_industry_secondary/views/res_config_settings.xml @@ -10,39 +10,11 @@ - - - - - - - - - Enable industries for individuals - - - - - - - - - + + + + + diff --git a/partner_industry_secondary/views/res_partner_view.xml b/partner_industry_secondary/views/res_partner_view.xml index 69355b307252..40116503139e 100644 --- a/partner_industry_secondary/views/res_partner_view.xml +++ b/partner_industry_secondary/views/res_partner_view.xml @@ -13,14 +13,13 @@ - - {'invisible': [('is_company', '=', False), ('show_partner_industry_for_person', '=', False)]} - + is_company == False and show_partner_industry_for_person == False @@ -52,10 +49,9 @@ - +