Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][ADD]sale_invoice_disable_salesperson_autosubscribe: disables salesperson autosubscription when creating invoices. #3295

Closed
wants to merge 1 commit into from
Closed

[17.0][ADD]sale_invoice_disable_salesperson_autosubscribe: disables salesperson autosubscription when creating invoices. #3295

wants to merge 1 commit into from

Conversation

RogerSans
Copy link

@RogerSans RogerSans commented Aug 30, 2024 •
edited
Loading

Disables salesperson autosubscription when creating invoices.
T-6499

@HaraldPanten
@ValentinVinagre
@luis-ron

luis-ron
luis-ron approved these changes Aug 30, 2024
View reviewed changes
Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM 👍🏻

@RogerSans
Copy link
Author

@ValentinVinagre Can you review PLS? THX

ValentinVinagre

This comment was marked as off-topic.

Sign in to view

@RogerSans RogerSans marked this pull request as draft August 30, 2024 07:45
@RogerSans RogerSans marked this pull request as draft August 30, 2024 07:45
@RogerSans RogerSans force-pushed the 17.0-add-sale_invoice_disable_salesperson_autosubscribe branch from 4573535 to 4ab9bef Compare August 30, 2024 11:12
@RogerSans RogerSans marked this pull request as ready for review September 5, 2024 08:11
luis-ron
luis-ron approved these changes Sep 9, 2024
View reviewed changes
Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: LGTM 👍🏻

@RogerSans
Copy link
Author

@manuelregidor Can you review this pls? THX

@pedrobaeza
Copy link
Member

You have to take into account that with this, salesmen won't be able to access the invoice, as the record rules in account.move are set by followers. The strategy should be that they don't receive the messages, not to prevent their subscription to the document. Maybe you can have them with a mail.subtype that is not disturbing.

[ADD]sale_invoice_disable_salesperson_autosubscribe: disables salespe…
a1ccd38 
…rson autosubscription when creating invoices.
@RogerSans RogerSans force-pushed the 17.0-add-sale_invoice_disable_salesperson_autosubscribe branch from 4ab9bef to a1ccd38 Compare September 9, 2024 11:16
@RogerSans
Copy link
Author

Thanks for the review Pedro. I'm actually changing it.

@RogerSans RogerSans marked this pull request as draft September 9, 2024 11:35
@HaraldPanten
Copy link
Contributor

@pedrobaeza Closing this PR which has been superseded by OCA/social#1460 which is more generic and follows better the good practices and OCA structure.

@HaraldPanten HaraldPanten deleted the 17.0-add-sale_invoice_disable_salesperson_autosubscribe branch October 10, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinVinagre ValentinVinagre ValentinVinagre requested changes

@luis-ron luis-ron luis-ron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RogerSans @pedrobaeza @HaraldPanten @ValentinVinagre @luis-ron