Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] mail_send_confirmation #1074

Closed

Conversation

AungKoKoLin1997
Copy link
Contributor

This module shows confirmation dialog when send mail to the customers.
The purpose of this module is to avoid a mail is sent to the customer instead of an internal note on the chatter.

@qrtl

@AungKoKoLin1997
Copy link
Contributor Author

pre-commit is failing because of eslint. I am not expert at odoo javascript. If anyone can suggest me better approach for this module, I am always welcome and ready to make adjustment.

@yostashiro
Copy link
Member

Tested on runboat. While it works on the send button in the chatter, no confirmation is requested when you switch to the message modal, which I think makes this solution incomplete.

2023-02-25_16-12-25

I was wondering if it would make the design simpler if we:

  • add a 'I understand that the message will be sent to the external follower(s)' checkbox in the template and disable the 'Send' button if the checkbox is not selected, and
  • do the same for the message modal

Another approach I thought was to migrate https://github.com/OCA/web/tree/14.0/web_send_message_popup to 15.0 (there is already a PR) and add an option in this module to request for a confirmation before sending the message.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 13, 2023
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-mail_send_confirmation branch from 349c186 to d7479f5 Compare September 14, 2023 03:22
@github-actions github-actions bot closed this Oct 15, 2023
SiesslPhillip pushed a commit to grueneerde/OCA-social that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/social (17.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants