-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] mail_send_confirmation #1116
Conversation
Functional test: Works as expected! |
@@ -0,0 +1 @@ | |||
This module asks confirmation when sending mail to the followers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module asks confirmation when sending mail to the followers. | |
This module asks for confirmation when 'Send' button in the message composer of the chatter is pressed, to reduce the chances of accidentally sending an internal message to the external followers. | |
Limitation | |
~~~~~~~~~~ | |
As of now, this module does not change the behavior of the full composer (i.e. no confirmation will be requested), which shows the recipients and therefore the extra confirmation step may not be as necessary as in the simple composer. |
Let's add more information.
@AungKoKoLin1997 Thanks! Can you please do the same for #1074. |
1c73a78
to
b6efdbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review, nice little addon!
This PR has the |
4baf20b
to
9ece836
Compare
@OCA/social-maintainers Is it possible to take a look at this PR? |
9ece836
to
72b9cd4
Compare
@OCA/social-maintainers reminder |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1116-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
72b9cd4
to
6d376d4
Compare
@dreispt I think merge was failed because of missing |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 3f6cf09. Thanks a lot for contributing to OCA. ❤️ |
This module asks for confirmation when 'Send' button in the message composer of the chatter is pressed, to reduce the chances of accidentally sending an internal message to the external followers.
@qrtl