Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] mail_send_confirmation #1116

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Mar 29, 2023

This module asks for confirmation when 'Send' button in the message composer of the chatter is pressed, to reduce the chances of accidentally sending an internal message to the external followers.

@qrtl

@rinaldifirdaus
Copy link

Functional test: Works as expected!

@@ -0,0 +1 @@
This module asks confirmation when sending mail to the followers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module asks confirmation when sending mail to the followers.
This module asks for confirmation when 'Send' button in the message composer of the chatter is pressed, to reduce the chances of accidentally sending an internal message to the external followers.
Limitation
~~~~~~~~~~
As of now, this module does not change the behavior of the full composer (i.e. no confirmation will be requested), which shows the recipients and therefore the extra confirmation step may not be as necessary as in the simple composer.

Let's add more information.

@yostashiro
Copy link
Member

@AungKoKoLin1997 Thanks! Can you please do the same for #1074.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-mail_send_confirmation branch from 1c73a78 to b6efdbd Compare April 11, 2023 10:12
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, nice little addon!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rinaldifirdaus rinaldifirdaus force-pushed the 16.0-add-mail_send_confirmation branch from 4baf20b to 9ece836 Compare April 11, 2023 15:01
@AungKoKoLin1997
Copy link
Contributor Author

@OCA/social-maintainers Is it possible to take a look at this PR?

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-mail_send_confirmation branch from 9ece836 to 72b9cd4 Compare August 10, 2023 08:56
@CasVissers-360ERP
Copy link

@OCA/social-maintainers reminder

@dreispt
Copy link
Member

dreispt commented Dec 27, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1116-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 27, 2023
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1116-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-mail_send_confirmation branch from 72b9cd4 to 6d376d4 Compare December 28, 2023 01:21
@AungKoKoLin1997
Copy link
Contributor Author

@dreispt I think merge was failed because of missing __init__.py . I added it. Can you please try again?

@dreispt
Copy link
Member

dreispt commented Dec 28, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1116-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4a2c2e3 into OCA:16.0 Dec 28, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3f6cf09. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants